* [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock
@ 2017-04-03 11:11 Julien Beraud
2017-04-11 15:50 ` Ley Foon Tan
0 siblings, 1 reply; 2+ messages in thread
From: Julien Beraud @ 2017-04-03 11:11 UTC (permalink / raw)
To: linux-kernel, nios2-dev; +Cc: lftan, Julien Beraud
Use spin_lock/unlock_irq instead of doing nothing. This fixes corruptions
of the vma_interval_tree causing the kernel to be stuck in an
infinite loop in vma_interval_tree_foreach.
Signed-off-by: Julien Beraud <julien.beraud@spectracom.orolia.com>
---
arch/nios2/include/asm/cacheflush.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/nios2/include/asm/cacheflush.h b/arch/nios2/include/asm/cacheflush.h
index 52abba973dc2..55e383c173f7 100644
--- a/arch/nios2/include/asm/cacheflush.h
+++ b/arch/nios2/include/asm/cacheflush.h
@@ -46,7 +46,9 @@ extern void copy_from_user_page(struct vm_area_struct *vma, struct page *page,
extern void flush_dcache_range(unsigned long start, unsigned long end);
extern void invalidate_dcache_range(unsigned long start, unsigned long end);
-#define flush_dcache_mmap_lock(mapping) do { } while (0)
-#define flush_dcache_mmap_unlock(mapping) do { } while (0)
+#define flush_dcache_mmap_lock(mapping) \
+ spin_lock_irq(&(mapping)->tree_lock)
+#define flush_dcache_mmap_unlock(mapping) \
+ spin_unlock_irq(&(mapping)->tree_lock)
#endif /* _ASM_NIOS2_CACHEFLUSH_H */
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock
2017-04-03 11:11 [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock Julien Beraud
@ 2017-04-11 15:50 ` Ley Foon Tan
0 siblings, 0 replies; 2+ messages in thread
From: Ley Foon Tan @ 2017-04-11 15:50 UTC (permalink / raw)
To: Julien Beraud, linux-kernel, nios2-dev
On Mon, 2017-04-03 at 13:11 +0200, Julien Beraud wrote:
> Use spin_lock/unlock_irq instead of doing nothing. This fixes
> corruptions
> of the vma_interval_tree causing the kernel to be stuck in an
> infinite loop in vma_interval_tree_foreach.
>
> Signed-off-by: Julien Beraud <julien.beraud@spectracom.orolia.com>
> ---
> arch/nios2/include/asm/cacheflush.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nios2/include/asm/cacheflush.h
> b/arch/nios2/include/asm/cacheflush.h
> index 52abba973dc2..55e383c173f7 100644
> --- a/arch/nios2/include/asm/cacheflush.h
> +++ b/arch/nios2/include/asm/cacheflush.h
> @@ -46,7 +46,9 @@ extern void copy_from_user_page(struct
> vm_area_struct *vma, struct page *page,
> extern void flush_dcache_range(unsigned long start, unsigned long
> end);
> extern void invalidate_dcache_range(unsigned long start, unsigned
> long end);
>
> -#define flush_dcache_mmap_lock(mapping) do { } while
> (0)
> -#define flush_dcache_mmap_unlock(mapping) do { } while (0)
> +#define flush_dcache_mmap_lock(mapping) \
> + spin_lock_irq(&(mapping)->tree_lock)
> +#define flush_dcache_mmap_unlock(mapping) \
> + spin_unlock_irq(&(mapping)->tree_lock)
>
> #endif /* _ASM_NIOS2_CACHEFLUSH_H */
> --
> 2.11.0
>
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
Regards
Ley Foon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 7:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-03 11:11 [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock Julien Beraud
2017-04-11 15:50 ` Ley Foon Tan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox