From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbdDKSQD (ORCPT ); Tue, 11 Apr 2017 14:16:03 -0400 Received: from smtprelay0225.hostedemail.com ([216.40.44.225]:38806 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752291AbdDKSQA (ORCPT ); Tue, 11 Apr 2017 14:16:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21323:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: size61_51054bfedf83c X-Filterd-Recvd-Size: 1623 Message-ID: <1491934554.17839.13.camel@perches.com> Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files From: Joe Perches To: Greg Kroah-Hartman , Thierry Escande Cc: linux-kernel@vger.kernel.org, Julia Lawall , cocci Date: Tue, 11 Apr 2017 11:15:54 -0700 In-Reply-To: <20170411140919.GC4388@kroah.com> References: <1491902071-17935-1-git-send-email-thierry.escande@collabora.com> <1491902071-17935-2-git-send-email-thierry.escande@collabora.com> <20170411140919.GC4388@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote: > Care to use "real" kernel variable types please? u8, u16, and others > are you friend, uint8_t really isn't what we prefer, and checkpatch > should tell you that... checkpatch doesn't warn about "u?int\d+_t" types unless --strict is enabled and most likely it shouldn't. There are about 100k uses of those types in the kernel. Many are uapi and are perhaps properly used in drivers and lib. checkpatch can't tell what type a particular use should have. Maybe coccinelle could based on whether the include comes from a uapi directory or prototype or some such.