From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbdDKSue (ORCPT ); Tue, 11 Apr 2017 14:50:34 -0400 Received: from smtprelay0193.hostedemail.com ([216.40.44.193]:38842 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752963AbdDKSub (ORCPT ); Tue, 11 Apr 2017 14:50:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3868:3871:3872:3873:3874:4321:5007:8531:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21323:21433:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: wheel25_5b8c243de840b X-Filterd-Recvd-Size: 1872 Message-ID: <1491936627.17839.22.camel@perches.com> Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files From: Joe Perches To: Greg Kroah-Hartman Cc: Thierry Escande , linux-kernel@vger.kernel.org, Julia Lawall , cocci Date: Tue, 11 Apr 2017 11:50:27 -0700 In-Reply-To: <20170411184233.GB26792@kroah.com> References: <1491902071-17935-1-git-send-email-thierry.escande@collabora.com> <1491902071-17935-2-git-send-email-thierry.escande@collabora.com> <20170411140919.GC4388@kroah.com> <1491934554.17839.13.camel@perches.com> <20170411184233.GB26792@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-11 at 20:42 +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 11, 2017 at 11:15:54AM -0700, Joe Perches wrote: > > On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote: > > > Care to use "real" kernel variable types please? u8, u16, and others > > > are you friend, uint8_t really isn't what we prefer, and checkpatch > > > should tell you that... > > > > checkpatch doesn't warn about "u?int\d+_t" types unless > > --strict is enabled and most likely it shouldn't. > > For brand new drivers, it's a good thing to run, to keep maintainers > from complaining about obvious things :) --strict emits some messages that are either unacceptable or unnecessary to some maintainers. 'course checkpatch itself is unacceptable and unnecessary to some maintainers too. cheers, Joe