From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756407AbdDMUq3 (ORCPT ); Thu, 13 Apr 2017 16:46:29 -0400 Received: from mail-bn3nam01on0067.outbound.protection.outlook.com ([104.47.33.67]:32113 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755810AbdDMUqZ (ORCPT ); Thu, 13 Apr 2017 16:46:25 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1492116375.17723.15.camel@nxp.com> Subject: Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints From: Leonard Crestez To: Mark Brown CC: Sascha Hauer , Liam Girdwood , Viresh Kumar , "Rafael J. Wysocki" , Shawn Guo , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , "Octavian Purdila" , , , , Date: Thu, 13 Apr 2017 23:46:15 +0300 In-Reply-To: <20170407112212.gzv3p7ldkh62657m@sirena.org.uk> References: <1edff9bc610969b0c53fa1080d5db021c8e00b2d.1490199005.git.leonard.crestez@nxp.com> <20170324125212.vikgekqxsnu7htzl@sirena.org.uk> <1490704781.3546.57.camel@nxp.com> <20170328164754.z2c2ttovs3sxbcos@sirena.org.uk> <1490730595.15830.1.camel@nxp.com> <20170406185202.uixxcv3dgucrddgc@sirena.org.uk> <1491562312.9365.41.camel@nxp.com> <20170407112212.gzv3p7ldkh62657m@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131365899817430482;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39860400002)(39400400002)(39850400002)(39840400002)(39410400002)(39380400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(199003)(377424004)(189002)(24454002)(9170700003)(4326008)(5820100001)(104016004)(39060400002)(2950100002)(93886004)(38730400002)(110136004)(47776003)(6916009)(8656002)(189998001)(305945005)(229853002)(8676002)(356003)(54906002)(53936002)(81166006)(8936002)(50226002)(50466002)(2906002)(103116003)(50986999)(6246003)(86362001)(230700001)(76176999)(7416002)(105606002)(23676002)(106466001)(57986006)(77096006)(85426001)(33646002)(36756003)(5660300001)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB1291;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD006;1:ZJVAZQr/IMHom/kdPAhzDi4b4WrZhmr9QEFeHpMqCEfWHsqi+lL18cy6aYJLPk3iE2HFPkX9FXLVC6UsXp070+sy4UNR+Qw3dR27EfNx/4Om0cTe7oCl2pkU/BMQWVhM2IVIFih73KjPWh3ynF2jHm3nDPrLZG/Ihvm6t0HtYjqL/INZKzhPEKZhR6z18YDBm69HQ02cJXVkzsOZBVNACVZj2BkkoBs6VYNQcUiiBrQKOhpkdvBlbzslD3GeHKT4kjuboUHgRj2/q5/BTCT4tG1th+fVJr51xH7qDpZExYAHfSH+L5R7A2GFjldH+AagZq8JMqfg1eBDCr/7ZGaB+iyNa4B92eju5MKskS01UCNoyspot/IZcLg06Sj6HjqbkT+rkaYEwkd48A1ezk60dms/Pck7taVfBVOVeI14k6drTZBd0TzmOiT78MTiagWDPx4MTzHnQsRbA8QkyyNvHcjDUIBuLl9sADMP0L9gOOWY8m1aC9vN4cSz+QmhQaFoPchxVl/+TydkAbulM7RehbbvsAy26+iBxikiANstcpqz2ZYc7qNCT7nRd7LXKvnJXwyS1Vk7n8xEkqDN0aqRwYmVQCEY6OwNmdBLL6ceBt2xX47VlE+iaUzWUiukczsp5WkEEtnzcDDIxwYu4UjkpA== X-MS-Office365-Filtering-Correlation-Id: ce8dcfe6-e846-42dd-add2-08d482ae24ae X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:CY1PR0301MB1291; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;3:ke4FGNuHA0gx9TZ6KLtMpIL1W0mMTnIVBjgn0kwyXBSp8GsdbEzSIylbRAFptDeFlj1ithBGTVHGDCUwgQvi6RJMiI4lJmE7WicsdOqGvhY3Rn7Cx1D8O7w2GH5O+R9TiVkm53UG+Wmc0SXLC+4sw7JJ7O2zU4jAsBmuk1KEYTDmyOsUuOcv0bdSxdodEVwbwSvZ41dGC6BxdGiFA4AGH/xKt09EdDUuGzNdEKUSJCgxFKmhv3KGYRDxFlbN6AuBOM1Ygsp5xxNb/rKd0WlaZSgAFdbH+d6T8i4knHSevuZpou7W4t4H5ELysw7g7ZeU/BlCyzl4nzOLohC3cZVpqqq+Y8jbVU1cgQ4mdbrXN86b5exeCqOemjQCykp2M2dtCQb8YTFh4g7WnaZa1Jj2c3ubg/Tlp/4NlIJQ36MbzN1HjSVyNJw3pb9KTXG64k9m;25:6ULexJJxlW69enE0Y2m7v84EULvKMn2V6OLtCelr2O/9Z61Kuwy0h0EfyHqxulQB8ZJfTPVu/BTQg+Scb7z/3o1ItFByjJgT8CUIWKHA/aVwNz3bQxl/zoI7sUSWA8GJi3mfT0uR5Sj+pk4Z7WQTxZeYCx7Wan04/1WAFFJkXSf1xAIFSmf4S0yX4e7u8s7ZH1bC5Nf2qx7TkuhohXzkAGV4OTW8/iRTy1jP99AhtulJSEbpJ0TgxCVHKSinf72MZ7RjvyFbvX6jxIDpTG3Kl41/1/Jft8+G202oVF02YwSMyM8+tzkPFL4QcfiFq+HlbVFrSrWkxBDZMsOKhmtHtYegpQmYHIyH/XtpitRvPHsdYSlmtJ/Nioxi+/tbf21ZITC3LRkNxeRgnNNnkRFJJwNjCCimuKu2pA3OcDSbkHEjfju5GPvh4oyhcLhtvdO31s5ZuFObqN4lxhVJtuonjg== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;31:FlnmtLQu2EPtcBOsUa1e6Kl4+o8ue1vrb3RNNXD9hvGRo5ua3YHnGkDmxm3MI6PZ1Oq3bevpwHtzGB69LjeVL/UzLVeZpNPlAerQzJez7AXim16ZgF1lJ+FiYn5CssJxwnKktnQQdBNN72wDqbH7IdEhT1osElOrzPJpKwXIQyZ+xKwqBPtgkMBZJjLTIVpgKMg0YnvediloEd+y2HySmtGa7maiQhmDLOXJQ51NPQTuA4D5WORjW8AbCJqHAGp7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13017025)(5005006)(8121501046)(13024025)(13023025)(13015025)(13018025)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259075);SRVR:CY1PR0301MB1291;BCL:0;PCL:0;RULEID:(400006);SRVR:CY1PR0301MB1291; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;4:3dY0gj7yDXb3DmYaZJPQF1+D9tf6dpsi54MCw6FvvLPBbDdmudtbHkNFSGUQH6LLSe5Nkj3pdkSBasVdn0pkJAHjKl0QKp9KJjOyXW2znB/hTItV3OIihOQig3DR89jfVSSWiae0zNThIRZObPjs/pxEaYysWbwSYh/5GFJtQy1f/GquxicRnzhtvtkbryxF8IA00YuIFPsgk0lkQoLoSb0xsDh4JNBqB1pg/CA/vP7qGTV52qjIKYJP4Rkx3sNCFR6flUdYpO1E6JbtjmvbK0kwE11xC/t/prjh3FAeO3N5trrZERvl69UxmdorezWeUTZlu9x7mFcFVMWdv7UiV25uLLH0nFtGoepQCZrk6xP+e7mN8z1RBiAnUq2HqOfS0dtgtN9zQ5CWOR1jhXUDMwU0cw/Q6Rf35K/+5rGmYNcEdqNkUx+5hbM3YQb6kA2A9DePRbcYPwFxtyk7Hwg7hyNMVo0XkKDkvDVxcKgwxJscKlsa1QZeoyg1WbXedCjcE1D7xP6aQek5DtU6BL4EvfZZAYjHndhPAyE80fvQVOv7L9Z8PstU9kMraQ/ptcYaGb1A7cIlMhDw+upHdJIUGJt8g5zZfo/mH3k4xHoOgyL6TPMMMr1QsIB3hUHNkOCiVk0F62hkdnXA50kG7zxnB3qdGkRVL/R9xsDyFsF5CPYuYUcrNkexZBwqM2XCTu2u5dyCkoam3jmMOp9YETR6ljykBVuFnphCckOSVPTPRl2yv589XOy19JZ08aaS9zdimRY3OKRFemjP4jkJPzO/2aKXoNkPUx+PhLNRtCst4AAhXXZfDnyhBZNaUC2DeQV2ktlcnIxT4hDY/axeI6iy3g== X-Forefront-PRVS: 02760F0D1C X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjEyOTE7MjM6Q1FPLzRZemd2OW1ndUN1RUpTenkyOC90?= =?utf-8?B?VVZ1a0o3dkVrcHlRWkhtSUN4dnVjUXlMcWlUbnp2c2VQNlF3TSs1VktnUTJS?= =?utf-8?B?NSswcFNORTVQWjZwR09qZmJ0aXYvdHk4Mkw4WmNUMENpM2twMjlhL0xjdENO?= =?utf-8?B?YTFyRU5DN0hKOHdTQzJyWFo0VXlRS3Z1UzhNWmhsTTNySitmVHFkeUhDSml4?= =?utf-8?B?TTc0Wk5FYzQxRFVzVDZOVGNjMHZLQUFxSGtNbE9IN29oT3daeEZBY3RzSlRD?= =?utf-8?B?VnZ2R2dyZkV5SUl5T04zcERxOEh1VFN0R2Z1Zk5CT0tpeWJhTWtXYTQ2YU12?= =?utf-8?B?QmZQd0RZaWgxN3c2clkwWnM3N0JGbEdFUlJKdU9BQVhDbXZIR3FHT09aWW05?= =?utf-8?B?ZHEva0M5anR3Wm8zcEdEOFI5Q1A5REpLcng4L29uVFNCWEU4a2ZsVjNsT2pQ?= =?utf-8?B?S1J6WTRyTTNjeTM0WWhURjFSTEpvVUcrU054dkJCamxrTk1lMXFpK0p2Mlpw?= =?utf-8?B?RmU0MGwvQVBXUW1FZHhaV2I5c1BXYUtOQk90czZqZ2J4MHlEQnJHbGV0dTQv?= =?utf-8?B?Rm54U1h2RkdGdzkvQlV4ZGdQNFJKMEttMjcvdCtyRUVoZGJKRk8rdk0yWHFv?= =?utf-8?B?b1VBWHRDbXI5VGdTd3ovTkpNeFh4WmNxaHd0R0s0eWtjd29hbUxYK053L2pG?= =?utf-8?B?bzUxT1VIR0doOHpIR092dVNtd3FDSmdSTVRBTjdTTGMwVHJQdFR0M2dNOTNY?= =?utf-8?B?WTNjNUpWZnlwbVNTSFVCWTVjdEpBRHpQcHVJTUlCV0RLR014TFV5TmxncjM3?= =?utf-8?B?RHNLTk9zOUxuT01WcXJ4dVN5R3VHNEFqV0thR1hYOW9HY2NGSmNOZEVUSTFH?= =?utf-8?B?eVBHYVltRDNvTjU0M3hiaTZXSEVwQjMrMHB1WDZUMHU1NUdCczh6T0RIVHFV?= =?utf-8?B?b1I5L3lsZW05ZnlvcmNYTkJJUVVteGlLbWFEYXI2RHgyakNVR2pxV2pLU1NO?= =?utf-8?B?VFNEalc1ZkQ5cEZFQ2xrY0s5TStMcldOdGROOGp5YTRMcmtKaXdwWVA0Ky9C?= =?utf-8?B?M3ZpZVRCMVBqRVdteTNDOTdVNHNKNXpRVnpIeDNEVlNWUGI3MEVvV3U2OStJ?= =?utf-8?B?OCt3ZUFDODh4ZVY0UytXN3FaTWJyZytVamEwZXhOallkWHNlQmpFYlJzV0I2?= =?utf-8?B?czV6ei9QNG80RUY3MWpLZ04wSEJyOWhzblZKck1GMjltT0lBUGx2V2U2VWtj?= =?utf-8?B?WDhGT0xrQzJVaXgraDhNZnVuVSt6aHl4N0U4ZVdxOWkrRmVxN1NkUXJleFJG?= =?utf-8?B?WWFaYUVBczFpQ1dQQklacmVpUEd0cEhKQWMrbWt3RWh2U1p4Q0taUWE4cEY5?= =?utf-8?B?OHFpbFVHSTFOQ0ppdzEyV0k3TjM0ZXhtbnpqSDBYcm9mdFRPdk14YjVMQjJP?= =?utf-8?B?bXl0K0k2ZHhGMVhKZklubC9BdTlXUkNVWFlVV0lrdUdoRTVPSXNVTFJoT2ZM?= =?utf-8?B?akNDemlVeEVVbGVNeWlLRVl3aC9EemNyZUlxVjYrQ2MwTjB1Mlk0NU4rWEZR?= =?utf-8?B?ZmlNMDBHaklmaU0xUERwMkw4WGgwOEN3WHFVUEJzVWJpUy9jQTM5bWx2UU5r?= =?utf-8?B?dERKdndmTUdSSGdlU0IzZ1p3VzhEREowTk8zWGtQTmdSNjY5TUJscmtmUDN1?= =?utf-8?B?bUFqTGxNM1c0UTJmQStjanYzTkZ4UHFIVFhpWUFDKzJsRTRCNDFza29RbnBX?= =?utf-8?B?VUNQUmI3WnVXUS90Zy9BWkFKeFZia0pVY0szaURSYW9tUHYveFVBL1gwT01M?= =?utf-8?B?aFh0aGZpdzZQK2lNUitSVnZYcEF0TU03NFd0bEV2RDVma3J4dUJEc3FicEd6?= =?utf-8?B?QTVjWlRyTlU3ZkpweVdtazBRanhyQnJhaDd1RVIvRUhtQ0h6TDl6NFpwa2J4?= =?utf-8?B?cUV0bGxkMmdwcUE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;6:j4dB4/PXMDJP5tFNflWW6HztrrvGQ5qB3Q5I4sFFIYIDR45T/+LewmZEdihKaquWdiMMFGblvrwhQJKTI9y9/IqnrivImpxjuJlzmhFRVrbESH5LG3b00FBKAlTmjlOhE3E8ziY2zVT+ESncnDAVcWnxrv8PgkDPCVJpfnzRDFQQXCtHPrzO8pYhGGEmGeq5WIYWSFg9PMOiT/hDpBXyTIPUWQt9O3XNXkJVN+GuRf5OACj7Uv58bgsPh2WkgUEaojiqxv6RytD5qGnibPoHjRU4fBR65JE2wP+/5v7pKAimV8ejcKsDhW5qlkx7HYH+uFx2PTcOK7RwOtElm2OI+t9YOHOgGSXysrUkk8YsG1dHEnCSg0IoytPE9MYvaeZa0o4+Qw/7fiBKxJprsGJpbDhpcMctYh0xeujsHBSdkUC+PdZflpJMW8L60aj4G76G7fQyKYyLjtBhssLRzLr+XA==;5:7tNrCWDgfFQI5cv0Px/8Wzk8htCLrrJBz/suboJfPy5Q20XMMgknU1r1+41OqzVHdHmDMiekB2boia55QEOdMRxAcBiSGADG248s5GtssNHhQbYvzvt4K7sxt2eUnmMwHLJ2egwsyCEkWzZma+9oTcajmuNo15jjNQDiCZQXJtxQY0M5uzxflLkl8uF1YGDE;24:NAw1CYixwOG2P6v3Yxj1XkXCH/WlgQ7isZ6mmdy5eO8nF4z0zugb+Ou93hj1ROvhPe/ulRdqkwgyE7ArAINVBzVFytV360NBQAHSebFhktA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1291;7:rWLzcBGRXZF/wcc0lrF09QoQouj48ugXbWJqSG3kcvSBKxF4n17JWzpuc38AvOhiXk20dW/QfPs+/CV9ZFUihuH2b0ZySYgm1XuYBCtfwde9iZlJT138b+H0/Hdw7G8vhh9ca9+bEAvPAk0HGPL8NjXUDqOPbDCnOLgoUNTp5oLLe46QYNgN0ha58CT7hxaa5rZ+trAJ038WePBzVTlP2qbJ5H5yusVaw3jQwnt5Q4hxLbr/b/yEMb8ZJfscKxXQjndrJhG7qOYkDYv6DgnvMoCIs0CmS/Jl8jljpn4papoUvMlQOyg3+quxu34sGPDozA7gtXa5jDqWhiUckotG7Q== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2017 20:46:21.5090 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1291 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-07 at 12:22 +0100, Mark Brown wrote: > On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote: > > It currently seems to work how I expect but from your statement it's > > not clear if it's entirely intentional. > The current behaviour of bypassed regulators is intentional. I did not mean to imply that there is something wrong with bypassed regulators. I just wanted more information about how regulators (non- bypassed) pick their voltage when consumers allow a range. After some more reading through the code it seems that the driver itself receives the range (either through set_voltage or map_voltage) and gets to make the choice. So it seems fine for my concerns, sorry to bother you. -- Regards, Leonard