From: Alan Cox <alan@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular
Date: Fri, 14 Apr 2017 21:42:54 +0100 [thread overview]
Message-ID: <1492202574.3693.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170414081242.GA5096@kroah.com>
> I'm pretty sure we want this code to be built as a module, so maybe a
> Kconfig change would resolve the issue instead?
>
> Alan, any thoughts?
It's a tiny chunk of platform helper code. It probably ultimately
belongs in arch/x86 somewhere or folded into the driver. At the moment
it won't build modular.
I'm fine with the change, it strips out more pointless code so helps
see what tiny bits of code in there are actually used for anything
real.
Alan
prev parent reply other threads:[~2017-04-14 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 1:57 [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular Paul Gortmaker
2017-04-14 8:12 ` Greg Kroah-Hartman
2017-04-14 15:57 ` Paul Gortmaker
2017-04-14 20:42 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492202574.3693.1.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox