From: Joe Perches <joe@perches.com>
To: surenderpolsani <surenderpolsani@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Larry.Finger" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] remove return statement
Date: Fri, 14 Apr 2017 22:17:07 -0700 [thread overview]
Message-ID: <1492233427.8661.1.camel@perches.com> (raw)
In-Reply-To: <1492232735-3516-1-git-send-email-surenderpolsani@gmail.com>
On Sat, 2017-04-15 at 10:35 +0530, surenderpolsani wrote:
> staging : rtl8188e : remove return in void function
Your patch subject isn't correct.
It should be something like:
Subject: [PATCH] staging: rtl8188e: Remove void function return
> kernel coding style doesn't allow the return statement
> in void function.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
[]
> @@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
> skip_dm:
> /* Check GPIO to determine current RF on/off and Pbc status. */
> /* Check Hardware Radio ON/OFF or not */
> - return;
And the comments?
Are those supposed to be reminders of code to write?
next prev parent reply other threads:[~2017-04-15 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 5:05 [PATCH] remove return statement surenderpolsani
2017-04-15 5:17 ` Joe Perches [this message]
2017-04-15 6:54 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492233427.8661.1.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surenderpolsani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox