From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757463AbdDRQNk convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 12:13:40 -0400 Received: from shell.v3.sk ([92.60.52.57]:48570 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbdDRQNh (ORCPT ); Tue, 18 Apr 2017 12:13:37 -0400 Message-ID: <1492532010.28092.12.camel@v3.sk> Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module From: Lubomir Rintel To: Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jose Abreu , Arnd Bergmann Date: Tue, 18 Apr 2017 18:13:30 +0200 In-Reply-To: <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk> References: <20170418105954.23368-1-lkundrak@v3.sk> <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-18 at 16:18 +0100, Mark Brown wrote: > On Tue, Apr 18, 2017 at 12:59:54PM +0200, Lubomir Rintel wrote: > > It makes not sense: the whether the PIO PCM extension is used is > > hardcoded to the designware_i2s driver and designware_pcm doesn't > > have any module metadata, causing a kernel taint: > > > >   [   44.287000] designware_pcm: module license 'unspecified' taints kernel. > > > > Signed-off-by: Lubomir Rintel > > This is not a a good approach, there is no technical reason to force the > driver to be built in.  If you need a license tag in the module then add > that. I don't think designware_pcm is a separate driver. It looks tightly coupled with designware_i2s: you can either disable designware_pcm altogether at build time or always load it together with designware_i2s. See sound/soc/dwc/local.h: #if IS_ENABLED(CONFIG_SND_DESIGNWARE_PCM) void dw_pcm_push_tx(struct dw_i2s_dev *dev); int dw_pcm_register(struct platform_device *pdev); #else void dw_pcm_push_tx(struct dw_i2s_dev *dev) { } int dw_pcm_register(struct platform_device *pdev) {         return -EINVAL; } #endif Lubo