* [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()
@ 2017-04-19 7:29 SF Markus Elfring
2017-04-19 8:23 ` Mark Rutland
2017-04-19 13:04 ` Pawel Moll
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2017-04-19 7:29 UTC (permalink / raw)
To: Ingo Molnar, Mark Rutland, Pawel Moll, Sebastian Andrzej Siewior,
Suzuki K. Poulose, Thomas Gleixner
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Apr 2017 09:12:43 +0200
Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "devm_kcalloc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/bus/arm-ccn.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
index 4d6a2b7e4d3f..6375bda0b2a1 100644
--- a/drivers/bus/arm-ccn.c
+++ b/drivers/bus/arm-ccn.c
@@ -1520,10 +1520,10 @@ static int arm_ccn_probe(struct platform_device *pdev)
if (err)
return err;
- ccn->node = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_nodes,
- GFP_KERNEL);
- ccn->xp = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_xps,
- GFP_KERNEL);
+ ccn->node = devm_kcalloc(ccn->dev, ccn->num_nodes, sizeof(*ccn->node),
+ GFP_KERNEL);
+ ccn->xp = devm_kcalloc(ccn->dev, ccn->num_xps, sizeof(*ccn->node),
+ GFP_KERNEL);
if (!ccn->node || !ccn->xp)
return -ENOMEM;
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()
2017-04-19 7:29 [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() SF Markus Elfring
@ 2017-04-19 8:23 ` Mark Rutland
2017-04-19 13:04 ` Pawel Moll
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2017-04-19 8:23 UTC (permalink / raw)
To: SF Markus Elfring
Cc: Ingo Molnar, Pawel Moll, Sebastian Andrzej Siewior,
Suzuki K. Poulose, Thomas Gleixner, LKML, kernel-janitors
On Wed, Apr 19, 2017 at 09:29:24AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 19 Apr 2017 09:12:43 +0200
>
> Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
This looks reasonable to me. FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
I'll leave the final say to Pawel.
Mark.
> ---
> drivers/bus/arm-ccn.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
> index 4d6a2b7e4d3f..6375bda0b2a1 100644
> --- a/drivers/bus/arm-ccn.c
> +++ b/drivers/bus/arm-ccn.c
> @@ -1520,10 +1520,10 @@ static int arm_ccn_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - ccn->node = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_nodes,
> - GFP_KERNEL);
> - ccn->xp = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_xps,
> - GFP_KERNEL);
> + ccn->node = devm_kcalloc(ccn->dev, ccn->num_nodes, sizeof(*ccn->node),
> + GFP_KERNEL);
> + ccn->xp = devm_kcalloc(ccn->dev, ccn->num_xps, sizeof(*ccn->node),
> + GFP_KERNEL);
> if (!ccn->node || !ccn->xp)
> return -ENOMEM;
>
> --
> 2.12.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe()
2017-04-19 7:29 [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() SF Markus Elfring
2017-04-19 8:23 ` Mark Rutland
@ 2017-04-19 13:04 ` Pawel Moll
1 sibling, 0 replies; 3+ messages in thread
From: Pawel Moll @ 2017-04-19 13:04 UTC (permalink / raw)
To: SF Markus Elfring
Cc: LKML, kernel-janitors, IngoMolnar, Mark Rutland,
Sebastian Andrzej Siewior, Suzuki K. Poulose, Thomas Gleixner
On Wed, 2017-04-19 at 09:29 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 19 Apr 2017 09:12:43 +0200
>
> Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Fine with me. I'll queue it with a couple other CCN driver changes.
Will probably get into 4.13.
Regards!
Pawel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-19 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-19 7:29 [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() SF Markus Elfring
2017-04-19 8:23 ` Mark Rutland
2017-04-19 13:04 ` Pawel Moll
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox