From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965753AbdDSQOb convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 12:14:31 -0400
Received: from shell.v3.sk ([92.60.52.57]:53519 "EHLO shell.v3.sk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965665AbdDSQO3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 12:14:29 -0400
Message-ID: <1492618461.28092.18.camel@v3.sk>
Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
From: Lubomir Rintel <lkundrak@v3.sk>
To: Jose Abreu <Jose.Abreu@synopsys.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
Date: Wed, 19 Apr 2017 18:14:21 +0200
In-Reply-To: <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com>
References: <20170418105954.23368-1-lkundrak@v3.sk>
         <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk>
         <1492532010.28092.12.camel@v3.sk>
         <20170418171519.csiftftd434psyn5@sirena.org.uk>
         <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-04-19 at 17:12 +0100, Jose Abreu wrote:
> Hi Lubomir,
> 
> 
> On 18-04-2017 18:15, Mark Brown wrote:
> > On Tue, Apr 18, 2017 at 06:13:30PM +0200, Lubomir Rintel wrote:
> > 
> > > I don't think designware_pcm is a separate driver. It looks
> > > tightly
> > > coupled with designware_i2s: you can either disable
> > > designware_pcm
> > > altogether at build time or always load it together with
> > > designware_i2s.
> > 
> > Yes, they're closely coupled but we might still want them both as a
> > module.
> 
> Thanks for the patch but I agree with Mark.
> 
> For the record you can add "MODULE_LICENSE(“Dual MIT/GPL”)".

Sorry if I'm missing something; but I still fail to understand why is
that a good idea.

What is the point of having a pair of modules that depend on each other
and can only be loaded together?

> Best regards,
> Jose Miguel Abreu

Lubo