Re: [PATCH v2 03/16] fpga: mgr: API change to replace fpga load functions with single function

Alan Tull
2017-04-21T20:08:47Z

On Thu, Apr 20, 2017 at 9:09 AM, Alan Tull <atull@kernel.org> wrote:

> @@ -382,7 +377,13 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
> if (of_property_read_bool(nd->overlay, "encrypted-fpga-config"))
> info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
>
> - of_property_read_string(nd->overlay, "firmware-name", &firmware_name);
> + if (!of_property_read_string(nd->overlay, "firmware-name",
> + &firmware_name)) {
> + info->firmware_name = devm_kstrdup(dev, firmware_name,
> + GFP_KERNEL);

For those who weren't copied, the kbuild robot has kindly pointed out
that dev is
undeclared in this function. It's fixed two patches later, but I'll
need to fix it for
bisectibility in v3. I actually did bisectibility testing but got
tired and lazy near the
end. I built & functionality tested individually starting at HEAD,
working back to
about HEAD~11, and then started :/ skipping patches. Ugh.

Alan