[PATCH v2 12/16] fpga: region: add fpga-region.h header

Alan Tull
2017-04-20T14:14:42Z

* Create fpga-region.h.
* Export fpga_region_program_fpga.
* Move struct fpga_region and other things to the header.

This is a step in separating FPGA region common code
from Device Tree support.

Signed-off-by: Alan Tull <atull@kernel.org>
---
v2: split out from another patch
update author email
---
drivers/fpga/fpga-region.c | 26 +++++---------------------
include/linux/fpga/fpga-region.h | 29 +++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 21 deletions(-)
create mode 100644 include/linux/fpga/fpga-region.h

diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
index 3fd4674a..f1d1d36 100644
--- a/drivers/fpga/fpga-region.c
+++ b/drivers/fpga/fpga-region.c
@@ -18,6 +18,7 @@

#include <linux/fpga/fpga-bridge.h>
#include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-region.h>
#include <linux/idr.h>
#include <linux/kernel.h>
#include <linux/list.h>
@@ -26,24 +27,6 @@
#include <linux/slab.h>
#include <linux/spinlock.h>

-/**
- * struct fpga_region - FPGA Region structure
- * @dev: FPGA Region device
- * @mutex: enforces exclusive reference to region
- * @bridge_list: list of FPGA bridges specified in region
- * @mgr: FPGA manager
- * @info: fpga image specific information
- */
-struct fpga_region {
- struct device dev;
- struct mutex mutex; /* for exclusive reference to region */
- struct list_head bridge_list;
- struct fpga_manager *mgr;
- struct fpga_image_info *info;
-};
-
-#define to_fpga_region(d) container_of(d, struct fpga_region, dev)
-
static DEFINE_IDA(fpga_region_ida);
static struct class *fpga_region_class;

@@ -227,8 +210,8 @@ static int fpga_region_get_bridges(struct fpga_region *region,
* Program an FPGA using fpga image info.
* Return 0 for success or negative error code.
*/
-static int fpga_region_program_fpga(struct fpga_region *region,
- struct fpga_image_info *info)
+int fpga_region_program_fpga(struct fpga_region *region,
+ struct fpga_image_info *info)
{
struct device *dev = &region->dev;
int ret;
@@ -290,6 +273,7 @@ static int fpga_region_program_fpga(struct fpga_region *region,

return ret;
}
+EXPORT_SYMBOL_GPL(fpga_region_program_fpga);

/**
* child_regions_with_firmware
@@ -672,5 +656,5 @@ subsys_initcall(fpga_region_init);
module_exit(fpga_region_exit);

MODULE_DESCRIPTION("FPGA Region");
-MODULE_AUTHOR("Alan Tull <atull@opensource.altera.com>");
+MODULE_AUTHOR("Alan Tull <atull@kernel.org>");
MODULE_LICENSE("GPL v2");
diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h
new file mode 100644
index 0000000..1075f94
--- /dev/null
+++ b/include/linux/fpga/fpga-region.h
@@ -0,0 +1,29 @@
+#include <linux/device.h>
+#include <linux/fpga/fpga-mgr.h>
+#include <linux/fpga/fpga-bridge.h>
+
+#ifndef _FPGA_REGION_H
+#define _FPGA_REGION_H
+
+/**
+ * struct fpga_region - FPGA Region structure
+ * @dev: FPGA Region device
+ * @mutex: enforces exclusive reference to region
+ * @bridge_list: list of FPGA bridges specified in region
+ * @mgr: FPGA manager
+ * @info: FPGA image info
+ */
+struct fpga_region {
+ struct device dev;
+ struct mutex mutex; /* for exclusive reference to region */
+ struct list_head bridge_list;
+ struct fpga_manager *mgr;
+ struct fpga_image_info *info;
+};
+
+#define to_fpga_region(d) container_of(d, struct fpga_region, dev)
+
+int fpga_region_program_fpga(struct fpga_region *region,
+ struct fpga_image_info *image_info);
+
+#endif /* _FPGA_REGION_H */
--
2.7.4