From: Rik van Riel <riel@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
James Hartsock <hartsjc@redhat.com>,
stable@vger.kernel.org, Tim Wright <tim@binbash.co.uk>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers
Date: Thu, 20 Apr 2017 12:00:06 -0400 [thread overview]
Message-ID: <1492704006.8850.201.camel@redhat.com> (raw)
In-Reply-To: <1492702230-28462-2-git-send-email-fweisbec@gmail.com>
On Thu, 2017-04-20 at 17:30 +0200, Frederic Weisbecker wrote:
> (This restores commit 24b91e360ef521a2808771633d76ebc68bd5604b that
> got
> reverted by commit 558e8e27e73f53f8a512485be538b07115fe5f3c due to a
> regression where CPUs spuriously stopped ticking. The issue happened
> when a tick fired too early past its expected expiration: on IRQ exit
> the tick was scheduled again to the same deadline but skipped
> reprogramming because ts->next_tick still kept in cache the deadline.
> This has been fixed now with resetting ts->next_tick from the tick
> itself. Extra care has also been taken to prevent from obsolete
> values
> throughout CPU hotplug operations.)
>
Acked-by: Rik van Riel <riel@redhat.com>
next prev parent reply other threads:[~2017-04-20 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 15:30 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues Frederic Weisbecker
2017-04-20 15:30 ` [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers Frederic Weisbecker
2017-04-20 16:00 ` Rik van Riel [this message]
2017-04-20 15:30 ` [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming Frederic Weisbecker
2017-04-20 16:01 ` Rik van Riel
2017-04-20 17:56 ` Thomas Gleixner
2017-04-20 18:29 ` Frederic Weisbecker
2017-04-20 19:40 ` Thomas Gleixner
2017-04-20 23:27 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2017-04-21 14:00 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v2 Frederic Weisbecker
2017-04-21 14:00 ` [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492704006.8850.201.camel@redhat.com \
--to=riel@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim@binbash.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).