From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425174AbdDVPBR (ORCPT ); Sat, 22 Apr 2017 11:01:17 -0400 Received: from smtprelay0079.hostedemail.com ([216.40.44.79]:44804 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1424895AbdDVPAl (ORCPT ); Sat, 22 Apr 2017 11:00:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1801:1963:2393:2559:2562:2828:2898:2914:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:4321:4605:5007:7903:10004:10400:10848:11026:11232:11233:11473:11658:11914:12043:12296:12438:12740:12760:12895:13161:13229:13439:14181:14659:14721:21080:21212:21451:30012:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: voice88_225c30524204a X-Filterd-Recvd-Size: 2854 Message-ID: <1492873234.30293.38.camel@perches.com> Subject: Re: [PATCH] staging: wilc1000: Fixes Alignment should match open parenthesis From: Joe Perches To: richard@netpro.work, gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 22 Apr 2017 08:00:34 -0700 In-Reply-To: <20170422062830.30715-1-richard@netpro.work> References: <20170422062830.30715-1-richard@netpro.work> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-04-22 at 07:28 +0100, richard@netpro.work wrote: > This patch fixes the following checkpatch.pl > check: CHECK: Alignment should match open parenthesis Please strive for improved code for human readers and not just shutting up checkpatch. > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c [] > @@ -870,12 +870,12 @@ static int wilc_mac_open(struct net_device *ndev) > if (memcmp(wl->vif[i ^ 1]->bssid, > wl->vif[i ^ 1]->src_addr, 6)) > wilc_set_wfi_drv_handler(vif, > - wilc_get_vif_idx(vif), > - 0); > + wilc_get_vif_idx(vif), > + 0); > else > wilc_set_wfi_drv_handler(vif, > - wilc_get_vif_idx(vif), > - 1); > + wilc_get_vif_idx(vif), > + 1); Depending on alignment, perhaps a good bit of this code could use ether_addr_ functions. wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), ether_addr_equals(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 1]->src_addr)); The code could also be restructured to reduce indentation by using if / continue; if (ndev != wl->vif[i]->ndev) continue; Using a temporary for the repeated use of wilc_get_vif_idx(vif) would also help code length. > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c [] > @@ -1301,16 +1301,16 @@ static int set_pmksa(struct wiphy *wiphy, struct net_device *netdev, > > for (i = 0; i < priv->pmkid_list.numpmkid; i++) { > if (!memcmp(pmksa->bssid, priv->pmkid_list.pmkidlist[i].bssid, > - ETH_ALEN)) { > + ETH_ALEN)) { ether_addr_equals() > flag = PMKID_FOUND; > break; > } > } > if (i < WILC_MAX_NUM_PMKIDS) { > memcpy(priv->pmkid_list.pmkidlist[i].bssid, pmksa->bssid, > - ETH_ALEN); > + ETH_ALEN); ether_addr_copy() etc.