From: Eric Curtin <ericcurtin17@gmail.com>
To: thomas.petazzoni@free-electrons.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Eric Curtin <ericcurtin17@gmail.com>
Subject: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.
Date: Sat, 22 Apr 2017 16:26:09 +0100 [thread overview]
Message-ID: <1492874769-14446-1-git-send-email-ericcurtin17@gmail.com> (raw)
checkpatch spits out a warning about the 80 character line limit. Split
the parameters of these functions onto different lines. Put the ; with
the macro caller instead. Lined up parameters as there was another
CHECK warning about that.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 27 ++++++++++++++++++++-------
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index ec45043..3143050 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \
buf[i] = (type)va_arg(args, unsigned int); \
} \
va_end(args); \
- fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \
+ fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, \
+ par, \
+ par->info->device, \
+ type, \
+ buf, \
+ len, \
+ "%s: ", \
+ __func__); \
} \
\
va_start(args, len); \
@@ -41,7 +48,10 @@ void func(struct fbtft_par *par, int len, ...) \
ret = par->fbtftops.write(par, par->buf, sizeof(type) + offset); \
if (ret < 0) { \
va_end(args); \
- dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \
+ dev_err(par->info->device, \
+ "%s: write() failed and returned %d\n", \
+ __func__, \
+ ret); \
return; \
} \
len--; \
@@ -60,17 +70,20 @@ void func(struct fbtft_par *par, int len, ...) \
len * (sizeof(type) + offset)); \
if (ret < 0) { \
va_end(args); \
- dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \
+ dev_err(par->info->device, \
+ "%s: write() failed and returned %d\n", \
+ __func__, \
+ ret); \
return; \
} \
} \
va_end(args); \
} \
-EXPORT_SYMBOL(func);
+EXPORT_SYMBOL(func)
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
-define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, );
+define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16);
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, );
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.7.4
next reply other threads:[~2017-04-22 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 15:26 Eric Curtin [this message]
2017-04-22 23:36 ` [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2017-04-23 14:21 Eric Curtin
2017-04-28 10:07 ` Greg KH
2017-05-25 21:35 ` Eric Curtin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492874769-14446-1-git-send-email-ericcurtin17@gmail.com \
--to=ericcurtin17@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox