Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

Eric Curtin
2017-05-25T21:35:37Z

On 28 April 2017 at 11:07, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Apr 23, 2017 at 03:21:31PM +0100, Eric Curtin wrote:
>> checkpatch spits out a warning about the 80 character line limit. Split
>> the parameters of these functions onto different lines. Put the ; with
>> the macro caller instead. Lined up parameters as there was another
>> CHECK warning about that.
>>
>> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
>> ---
>> drivers/staging/fbtft/fbtft-bus.c | 36 +++++++++++++++++++++---------------
>> 1 file changed, 21 insertions(+), 15 deletions(-)
>
> Patch does not apply to my tree at all :(

Hi Greg,

Sorry I didn't realize you replied. I gave up on these drivers because
I read around and saw that these drivers are unlikely to ever be merged
properly into the mainline kernel, while they use this deprecated
framework:

https://github.com/notro/fbtft/wiki/Development

I know you were involved in some of these conversations:

https://lkml.org/lkml/2016/11/23/146

My main reason for helping with this, was so my rpi3 display would
"just work" on future distro's I installed. I'd struggle to port to
this new framework as I have no experience with drivers.