From: Joe Perches <joe@perches.com>
To: Pan Bian <bianpan2016@163.com>,
Jon Maloy <jon.maloy@ericsson.com>,
Ying Xue <ying.xue@windriver.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] tipc: check return value of nlmsg_new
Date: Sun, 23 Apr 2017 00:17:16 -0700 [thread overview]
Message-ID: <1492931836.30293.43.camel@perches.com> (raw)
In-Reply-To: <1492931359-25004-1-git-send-email-bianpan2016@163.com>
On Sun, 2017-04-23 at 15:09 +0800, Pan Bian wrote:
> Function nlmsg_new() will return a NULL pointer if there is no enough
> memory, and its return value should be checked before it is used.
> However, in function tipc_nl_node_get_monitor(), the validation of the
> return value of function nlmsg_new() is missed. This patch fixes the
> bug.
Hello.
Thanks for the patches.
Are you finding these via a tool or inspection?
If a tool is being used, could you please describe it?
next prev parent reply other threads:[~2017-04-23 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 7:09 [PATCH 1/1] tipc: check return value of nlmsg_new Pan Bian
2017-04-23 7:17 ` Joe Perches [this message]
2017-04-23 8:00 ` PanBian
2017-04-23 8:16 ` Joe Perches
2017-04-23 13:33 ` Jon Maloy
2017-04-24 19:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492931836.30293.43.camel@perches.com \
--to=joe@perches.com \
--cc=bianpan2016@163.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox