* [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
@ 2017-04-22 12:48 Colin King
2017-04-23 9:37 ` Boaz Harrosh
0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2017-04-22 12:48 UTC (permalink / raw)
To: Boaz Harrosh, Benny Halevy, osd-dev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in ORE_ERR message and make word all
lower case.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/exofs/ore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
index 8bb72807e70d..811522ae45e1 100644
--- a/fs/exofs/ore.c
+++ b/fs/exofs/ore.c
@@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
}
if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
ORE_ERR("Stripe Unit(0x%llx)"
- " must be Multples of PAGE_SIZE(0x%lx)\n",
+ " must be multiples of PAGE_SIZE(0x%lx)\n",
_LLU(layout->stripe_unit), PAGE_SIZE);
return -EINVAL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
2017-04-22 12:48 [PATCH] ore: fix spelling mistake: "Multples" -> "multiples" Colin King
@ 2017-04-23 9:37 ` Boaz Harrosh
2017-04-24 0:08 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Boaz Harrosh @ 2017-04-23 9:37 UTC (permalink / raw)
To: Colin King, Benny Halevy, osd-dev; +Cc: linux-kernel
On 04/22/2017 03:48 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in ORE_ERR message and make word all
> lower case.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks
ACK-by: Boaz Harrosh <ooo@electrozaur.com>
> ---
> fs/exofs/ore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
> index 8bb72807e70d..811522ae45e1 100644
> --- a/fs/exofs/ore.c
> +++ b/fs/exofs/ore.c
> @@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
> }
> if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
> ORE_ERR("Stripe Unit(0x%llx)"
> - " must be Multples of PAGE_SIZE(0x%lx)\n",
> + " must be multiples of PAGE_SIZE(0x%lx)\n",
> _LLU(layout->stripe_unit), PAGE_SIZE);
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
2017-04-23 9:37 ` Boaz Harrosh
@ 2017-04-24 0:08 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-04-24 0:08 UTC (permalink / raw)
To: Boaz Harrosh, Colin King, Benny Halevy, osd-dev; +Cc: linux-kernel
On Sun, 2017-04-23 at 12:37 +0300, Boaz Harrosh wrote:
> On 04/22/2017 03:48 PM, Colin King wrote:
> > trivial fix to spelling mistake in ORE_ERR message and make word all
> > lower case.
[]
> > diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
[]
> > @@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
> > }
> > if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
> > ORE_ERR("Stripe Unit(0x%llx)"
> > - " must be Multples of PAGE_SIZE(0x%lx)\n",
> > + " must be multiples of PAGE_SIZE(0x%lx)\n",
Perhaps better would be:
ORE_ERR("Stripe unit (0x%llx) must be a multiple of PAGE_SIZE (0x%llx)\n",
_LLU(layout->stripe_unit), PAGE_SIZE);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
@ 2018-03-28 23:07 Colin King
2018-03-28 23:21 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2018-03-28 23:07 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in ORE_ERR error message text and
make it all lowercase.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/exofs/ore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
index 3c6a9c156b7a..0df0b6d25d06 100644
--- a/fs/exofs/ore.c
+++ b/fs/exofs/ore.c
@@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
}
if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
ORE_ERR("Stripe Unit(0x%llx)"
- " must be Multples of PAGE_SIZE(0x%lx)\n",
+ " must be multiples of PAGE_SIZE(0x%lx)\n",
_LLU(layout->stripe_unit), PAGE_SIZE);
return -EINVAL;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"
2018-03-28 23:07 Colin King
@ 2018-03-28 23:21 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2018-03-28 23:21 UTC (permalink / raw)
To: Colin King, Boaz Harrosh; +Cc: kernel-janitors, linux-kernel
On Thu, 2018-03-29 at 00:07 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in ORE_ERR error message text and
> make it all lowercase.
thanks and more trivially:
> diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c
[]
> @@ -68,7 +68,7 @@ int ore_verify_layout(unsigned total_comps, struct ore_layout *layout)
> }
> if (0 != (layout->stripe_unit & ~PAGE_MASK)) {
> ORE_ERR("Stripe Unit(0x%llx)"
> - " must be Multples of PAGE_SIZE(0x%lx)\n",
> + " must be multiples of PAGE_SIZE(0x%lx)\n",
"a multiple" might be more intelligible than "multiples"
It would be a more common usage too.
$ git grep -i "\".*multiples" | wc -l
10
$ git grep -i "\".*a multiple" | wc -l
62
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-28 23:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-22 12:48 [PATCH] ore: fix spelling mistake: "Multples" -> "multiples" Colin King
2017-04-23 9:37 ` Boaz Harrosh
2017-04-24 0:08 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2018-03-28 23:07 Colin King
2018-03-28 23:21 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox