From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org, urban@teststation.com
Subject: Re: d_add on negative dentry?
Date: Tue, 6 Mar 2001 14:41:47 MET-1 [thread overview]
Message-ID: <1492C65485C@vcnet.vc.cvut.cz> (raw)
On 5 Mar 01 at 18:08, Alexander Viro wrote:
> On Tue, 6 Mar 2001, Urban Widmark wrote:
>
> >
> > Is it valid to call d_add on a negative dentry?
> > (or on a dentry that is already linked in d_hash, but all negative
> > dentries are, right?)
>
> Not all of them. It _is_ legal to do d_add() on a negative dentry.
> Doing that for hashed dentries is a bug. Use d_instantiate() instead.
> Cheers,
> Al
>
> PS: as for the patch, better make it
> d_instantiate(...);
> if (!hashed)
> d_rehash(...);
It could explain why I'm getting once a month CPU spinning in d_lookup()
because of some circular list is no more one circle...
Many thanks, I'll apply it to ncpfs ASAP.
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz
next reply other threads:[~2001-03-06 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-06 14:41 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-03-05 23:01 d_add on negative dentry? Urban Widmark
2001-03-05 23:08 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492C65485C@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=urban@teststation.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox