public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] SCSI fixes for 4.11-rc8
@ 2017-04-24 14:33 James Bottomley
  0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2017-04-24 14:33 UTC (permalink / raw)
  To: Andrew Morton, Linus Torvalds; +Cc: linux-scsi, linux-kernel

Our final fix before the 4.12 release (hopefully).  It's an error leg
again: the fix to not bug on empty DMA transfers is returning the wrong
code and confusing the block layer. 

The patch is available here:

git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes

The short changelog is:

Johannes Thumshirn (1):
      scsi: return correct blkprep status code in case scsi_init_io() fails.

With the diffstat:

 drivers/scsi/scsi_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

And full diff below.

James

---
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 19125d72f322..5558e212368b 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1061,10 +1061,10 @@ int scsi_init_io(struct scsi_cmnd *cmd)
 	struct scsi_device *sdev = cmd->device;
 	struct request *rq = cmd->request;
 	bool is_mq = (rq->mq_ctx != NULL);
-	int error;
+	int error = BLKPREP_KILL;
 
 	if (WARN_ON_ONCE(!blk_rq_nr_phys_segments(rq)))
-		return -EINVAL;
+		goto err_exit;
 
 	error = scsi_init_sgtable(rq, &cmd->sdb);
 	if (error)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-24 14:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-24 14:33 [GIT PULL] SCSI fixes for 4.11-rc8 James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox