From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1437311AbdDZJbD (ORCPT ); Wed, 26 Apr 2017 05:31:03 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:48431 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2995437AbdDZJU3 (ORCPT ); Wed, 26 Apr 2017 05:20:29 -0400 Message-ID: <1493198391.3653.4.camel@pengutronix.de> Subject: Re: [PATCH] reset: sti: Use devm_kcalloc() in syscfg_reset_controller_register() From: Philipp Zabel To: SF Markus Elfring Cc: kernel@stlinux.com, linux-arm-kernel@lists.infradead.org, Patrice Chotard , Srinivas Kandagatla , Stephen Gallimore , LKML , kernel-janitors@vger.kernel.org Date: Wed, 26 Apr 2017 11:19:51 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-04-26 at 10:05 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 09:50:34 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > * Delete the local variable "size" which became unnecessary with > this refactoring. > > Signed-off-by: Markus Elfring > --- > drivers/reset/sti/reset-syscfg.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c > index 9bd57a5eee72..7e0f2aa55ba7 100644 > --- a/drivers/reset/sti/reset-syscfg.c > +++ b/drivers/reset/sti/reset-syscfg.c > @@ -145,16 +145,14 @@ static int syscfg_reset_controller_register(struct device *dev, > const struct syscfg_reset_controller_data *data) > { > struct syscfg_reset_controller *rc; > - size_t size; > int i, err; > > rc = devm_kzalloc(dev, sizeof(*rc), GFP_KERNEL); > if (!rc) > return -ENOMEM; > > - size = sizeof(struct syscfg_reset_channel) * data->nr_channels; > - > - rc->channels = devm_kzalloc(dev, size, GFP_KERNEL); > + rc->channels = devm_kcalloc(dev, data->nr_channels, > + sizeof(*rc->channels), GFP_KERNEL); > if (!rc->channels) > return -ENOMEM; > Thank you, I have applied this to the reset/next branch. The same change could be made in the ti-syscon reset driver. regards Philipp