From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753052AbdD0FoP (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Apr 2017 01:44:15 -0400
Received: from mout.gmx.net ([212.227.17.20]:58914 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752693AbdD0FoF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Apr 2017 01:44:05 -0400
Message-ID: <1493271840.4154.25.camel@gmx.de>
Subject: Re: TREE_SRCU slows hotplug by factor ~16
From: Mike Galbraith <efault@gmx.de>
To: paulmck@linux.vnet.ibm.com
Cc: LKML <linux-kernel@vger.kernel.org>
Date: Thu, 27 Apr 2017 07:44:00 +0200
In-Reply-To: <20170427053228.GA11107@linux.vnet.ibm.com>
References: <1493220380.6176.2.camel@gmx.de>
         <20170426154402.GT3956@linux.vnet.ibm.com> <1493221799.6176.5.camel@gmx.de>
         <1493228757.4132.2.camel@gmx.de> <20170426175544.GW3956@linux.vnet.ibm.com>
         <20170426175610.GA6491@linux.vnet.ibm.com> <1493230330.4132.4.camel@gmx.de>
         <1493264639.4154.10.camel@gmx.de>
         <20170427041136.GA3956@linux.vnet.ibm.com>
         <1493266556.4154.11.camel@gmx.de>
         <20170427053228.GA11107@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:gF2hKkKEzPB0a7mD7/kYXL5KHb/us2py9yopYEJUVjUeLxg7+hD
 YV2WBYcthUHieE40RRhqNW06yiG1yk+mJpsWXILKW2YEH0R2UdL3QwK14++iBvlvnQibV4y
 dFOv+qjUsohf+KpG8XjjaOloZ07N3Z6Xi0bsiFAsF7yYdAXgulu+YHrv9xP4JG79ODY8wS6
 inIa5aoCov7AILwoYJOrg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:SvDWMRSGyW0=:AiNED20UjibOPS2zatWBEw
 d0/NZMgKP224+4zWPlbPIF1vgRHCWAkvkjCxbjfhVIaFS7VOvXjB4ezELiLFNtSLTXT3qUYKY
 wCHttFSgV5loVDUEVfpBunv0ZOU0Urtr8E7u4bju1msuslaf82ta4tWdGS7BNejQID226OUim
 pSBsSg9nA7SYETdwQToZsc2qwfRL9I0yV8glAz2lnXJQaFhfwPpOwmIdXR0I7eBo0tyJcGWE7
 rsXU1OsZPN4kBUiBcuONV9lWzZAa/gJz0tkhx0nU3VVJz9j6CH+ugr1vpTpobvAzbzbA8KjYx
 n2UIDA5oU+/bfw7Tf0Y2IBFZuUn/w/QrmQefopz6VBH7QRIoxRf8qji33u7P1Evd9y0ouv0q6
 OsiXQD7BGpmtLYTdNNUj44P8XUi1aHS5z2BqI+dsojou/XZ5kb6rUWc5tm4B3HVjbU8abVgXx
 s24BvLYoreN5bYNeV6tZt/wLY5KNM9vGInhgjPu8xQxgPkHdtu9Ih6tPDx7JQCIff0K34E/nm
 WENUpcw1LHOm/6/7HO75p/SJ4z2kUVIRYplcfQksILPWsWltvTyCT6leiujHIvcGQ59+8ni8n
 9blg+lhffqkFK1htAnbMZOlsf/1Cyk20oibgiw1H/AeFC4ZSySSGxOLQllrsjHvaV1FUCanSP
 xnt6ClrYLH3eOLCnUNNifbpgo+X8qor8luVzQhgY8MwMs9E67bpXxaF4K+J0nruFkWpY9ixLY
 cQjdzpUy+J+b8K5FY7c8vlv9nWv/rW2NlrWkDsYC6p+76/aSpz9yx2SHoLeLUtGkoZTvgSsXl
 19ceQ49
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-04-26 at 22:32 -0700, Paul E. McKenney wrote:
> On Thu, Apr 27, 2017 at 06:15:56AM +0200, Mike Galbraith wrote:
> > On Wed, 2017-04-26 at 21:11 -0700, Paul E. McKenney wrote:
> > 
> > > This is with srcutree.exp_holdoff set to 25*1000?
> > 
> > Yup.
> 
> And please see below for the trivial patch, just for confirmation.
> May I add your Tested-by?

Sure.

> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index ccbe1fb84165..65f03bca5b32 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -39,7 +39,7 @@
>  
>  #include "rcu.h"
>  
> -ulong exp_holdoff = 50 * 1000; /* Holdoff (ns) for auto-expediting. */
> +ulong exp_holdoff = 25 * 1000; /* Holdoff (ns) for auto-expediting. */

Yup, exactly what I did.