From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Justin Vreeland <justin@jvreeland.com>,
gregkh@linuxfoundation.org, hadess@hadess.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional
Date: Thu, 27 Apr 2017 17:27:31 -0700 [thread overview]
Message-ID: <1493339251.18659.58.camel@perches.com> (raw)
In-Reply-To: <d7336b66-872d-1c4d-4292-a29c8d1504a2@lwfinger.net>
On Thu, 2017-04-27 at 19:22 -0500, Larry Finger wrote:
> On 04/27/2017 07:09 PM, Justin Vreeland wrote:
> > Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> > ---
> > drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +++++----------
> > drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++------
> > drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++----
[]
> Fix the over-long lines and add a commit message.
Lines with 35+ long identifiers should probably stay > 80 columns
> > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
[]
> > @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> > Adapter->registrypriv.RegEnableTxPowerLimit == 1 ||
> > (Adapter->registrypriv.RegEnableTxPowerLimit == 2 && pHalData->EEPROMRegulatory == 1)
> > ) {
> > - if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL)
> > - {
> > + if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL) {
> > if (HAL_STATUS_SUCCESS != ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, (ODM_RF_RADIO_PATH_E)0))
> > rtStatus = _FAIL;
> > }
next prev parent reply other threads:[~2017-04-28 0:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 0:09 [PATCH 0/7] staging: rtl8732: Various checkpatch fixes Justin Vreeland
2017-04-28 0:09 ` [PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables Justin Vreeland
2017-04-28 0:09 ` [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop Justin Vreeland
2017-04-28 0:19 ` Larry Finger
2017-04-28 0:09 ` [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland
2017-04-28 0:20 ` Larry Finger
2017-04-28 0:09 ` [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland
2017-04-28 0:22 ` Larry Finger
2017-04-28 0:27 ` Joe Perches [this message]
2017-04-28 0:09 ` [PATCH 5/7] staging: rtl8723bs: Fix pointer style Justin Vreeland
2017-04-28 0:09 ` [PATCH 6/7] staging: rtl8723bs: Fix spacing around '<' Justin Vreeland
2017-04-28 0:10 ` [PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition Justin Vreeland
2017-04-28 9:49 ` [PATCH 0/7] staging: rtl8732: Various checkpatch fixes Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493339251.18659.58.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=justin@jvreeland.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox