From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tomohiro Yoshidomi <typesylph@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
sylph23k@gmail.com
Subject: Re: [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver
Date: Sat, 29 Apr 2017 23:10:30 +0200 [thread overview]
Message-ID: <1493500230.22420.6.camel@hadess.net> (raw)
In-Reply-To: <20170429181604.GA5562@dtor-ws>
Hey,
On Sat, 2017-04-29 at 11:16 -0700, Dmitry Torokhov wrote:
> "Say Y here if you wish to connect PSX (PS1/2) pad via SPI
> interface."
It should say "PlayStation 1/2 joypads". Using "Play Station" is
incorrect, PSX is a code name so you could mention it in between
brackets. Saying "pads" is also possibly confusing, Wacom tablets have
"pads", they're "joypads".
> Let's call it "PSX gamepad force feedback (rumble) support"
This should probably mention that it's force feedback support for the
PlayStation joypads when connected via SPI. Maybe it could be
automatically enabled if both the above driver is enabled and force
feedback is as well? That would save having to describe it too
verbosely.
A code comment: how does the output of this device compare to the
output of USB PlayStation adapters? It would be interesting to double-
check that what comes out of the kernel when connected either way is
the same.
Maybe Benjamin has captures for those adapters?
Cheers
prev parent reply other threads:[~2017-04-29 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 9:40 [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver Tomohiro Yoshidomi
2017-04-29 9:44 ` Tomohiro Yoshidomi
2017-04-29 18:16 ` Dmitry Torokhov
2017-04-29 21:10 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493500230.22420.6.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sylph23k@gmail.com \
--cc=typesylph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox