From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbdEAS2F (ORCPT ); Mon, 1 May 2017 14:28:05 -0400 Received: from mail-pg0-f49.google.com ([74.125.83.49]:33737 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdEAS1s (ORCPT ); Mon, 1 May 2017 14:27:48 -0400 Message-ID: <1493663247.10973.1.camel@debian.org> Subject: Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state From: Ritesh Raj Sarraf Reply-To: rrs@debian.org To: Darren Hart , Andy Shevchenko Cc: Platform Driver , Ike Panhc , "linux-kernel@vger.kernel.org" Date: Mon, 01 May 2017 23:57:27 +0530 In-Reply-To: <20170501160543.GA29387@fury> References: <20170217184756.15181-1-rrs@debian.org> <1487759058.9334.7.camel@debian.org> <1493448775.9725.5.camel@debian.org> <20170501160543.GA29387@fury> Organization: Debian Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-EKQs4on9NoR8H6MIQrUu" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-EKQs4on9NoR8H6MIQrUu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-05-01 at 09:05 -0700, Darren Hart wrote: > > sysfs ABI for drivers that provide input interface is quite strong for > > my opinion. It means I'm not totally objecting, but I would accept it > > if and only if there is nothing else could be done. >=20 > Agreed, we've recently wanted to remove certain sysfs attributes from ano= ther > driver as they were obsolete and better implemented in other ways, but on= ce > they > are there, are hands are tied. >=20 > That said, we will support getting these systems functional. From what I = see > in > the patch you are implementing a polling sysfs interface. Have you verifi= ed > that > there is no event we can capture and send the SW_TABLET_MODE along to the > input > system? I believe it does generate an event (at least on my Yoga 2 13 variant). IIR= C, when I talked to Andy initially about the driver's limitation, we did do an exercise [1] to determine if an event was generated. Cooking this patch (sysfs interface) was much quicker and easy. I looked at= the other example drivers, that do SW_TABLET_MODE, but left it there. I don't t= hink I have all the necessary information to get that done for the ideapad drive= r. [1] https://patchwork.kernel.org/patch/9546987/ --=20 Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System --=-EKQs4on9NoR8H6MIQrUu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAlkHfg8ACgkQpjpYo/Lh dWnWyw//Wm7L2KjYXqv+DsBGsSKbHf2YVpkwOrmf7jfjRGI+Vw8KfqLl/8HywYh8 2bdqi3gtI2Wmo1qPNhGuo3fKlXE0dH0qMmqn+5Wrs/ccQEUfhUQKZKpcfeC2LqwC 0kYNkoT5LOtSNoeAVfkEEWiD5Zz/L2z+IG5EdYInN8dG4ovRwFdBNOSqaVpWwDHY z9xB1sMn4X+DhpUOrXhIzmJoggTx99cFr3aS1xyt+PYKGcbGjUhOdMU1duyVRKOG p37btOVbKjTsShGfoBu4j/H9MaMKqWQMS413CTZUCnysAg6JXXn5YmTe2p7L2i1A mMdSE5Ya6pvb0Hs4PZEIsE4GObvHC8/EhMkSZ1UQE2NkhniBKCguBpi4BImAialK IWKoAON6sWuVNLk/HWPDKvLbSfVPE19eUscNGfstfnEQBpU0nFXEaL0jce73t8eu ENbSlhzBAKhkEwUbYukTtxUpEo/yvZPyk5y5QtWiTxmIna1oC3rZ0zemtiUMmvJu M7I3MN6JucBkAVX85WMfZ2iqpOvSczppBkmA5aBhuNGtTlQocVenR1eSgmBbF5S0 ADUAx3P7DN4E5Lq0R+u82Ig8dUronBUROxS9o1sXSKd5uW+WfdKu7tYVZNq+9z3j zIgy/mJQVsx1dvA83VCA+JZwBAjJ6j+DONg+bqvpAttvudK2+wc= =vkcZ -----END PGP SIGNATURE----- --=-EKQs4on9NoR8H6MIQrUu--