From: Gerd Hoffmann <kraxel@redhat.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Michel Dänzer" <michel@daenzer.net>,
"open list" <linux-kernel@vger.kernel.org>,
"amd-gfx mailing list" <amd-gfx@lists.freedesktop.org>,
"Pekka Paalanen" <ppaalanen@gmail.com>,
"Sean Paul" <seanpaul@chromium.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Alex Deucher" <alexdeucher@gmail.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Ilia Mirkin" <imirkin@alum.mit.edu>
Subject: Re: [PATCH 1/3] drm: fourcc byteorder: drop DRM_FORMAT_BIG_ENDIAN
Date: Tue, 02 May 2017 16:14:24 +0200 [thread overview]
Message-ID: <1493734464.8581.105.camel@redhat.com> (raw)
In-Reply-To: <CACvgo52FeXVixjmRpv3xO=kRFTbmBu5vmyzAs=VF_v+nLAO=ag@mail.gmail.com>
> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> > index 995c8f9c69..305bc34be0 100644
> > --- a/include/uapi/drm/drm_fourcc.h
> > +++ b/include/uapi/drm/drm_fourcc.h
> > @@ -33,8 +33,6 @@ extern "C" {
> > #define fourcc_code(a, b, c, d) ((__u32)(a) | ((__u32)(b) << 8) | \
> > ((__u32)(c) << 16) | ((__u32)(d) << 24))
> >
> > -#define DRM_FORMAT_BIG_ENDIAN (1<<31) /* format is big endian instead of little endian */
> > -
>
> Weston references DRM_FORMAT_BIG_ENDIAN thus this patch will lead to
> build breakage.
> Personally I would leave the symbol, since it's UAPI and document that
> should not be used.
Fair enough. I can surely add a deprecated comment instead of just
dropping it.
I'm wondering how it is used though, given that none of the drivers in
the kernel actually support this flag ...
cheers,
Gerd
next prev parent reply other threads:[~2017-05-02 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170502133404.15354-1-kraxel@redhat.com>
2017-05-02 13:34 ` [PATCH 1/3] drm: fourcc byteorder: drop DRM_FORMAT_BIG_ENDIAN Gerd Hoffmann
2017-05-02 13:53 ` Emil Velikov
2017-05-02 14:14 ` Gerd Hoffmann [this message]
2017-05-02 14:27 ` Pekka Paalanen
2017-05-02 15:06 ` Gerd Hoffmann
2017-05-02 17:57 ` Ilia Mirkin
2017-05-03 3:05 ` Michel Dänzer
2017-05-03 9:24 ` Gerd Hoffmann
2017-05-08 0:38 ` Michel Dänzer
2017-05-02 13:34 ` [PATCH 2/3] drm: fourcc byteorder: add DRM_FORMAT_CPU_* Gerd Hoffmann
2017-05-02 13:34 ` [PATCH 3/3] drm: fourcc byteorder: add drm_mode_legacy_fb_format_he Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493734464.8581.105.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=imirkin@alum.mit.edu \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=ppaalanen@gmail.com \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox