From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176AbdECAv0 (ORCPT ); Tue, 2 May 2017 20:51:26 -0400 Received: from smtprelay0083.hostedemail.com ([216.40.44.83]:36122 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751005AbdECAvZ (ORCPT ); Tue, 2 May 2017 20:51:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:2:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1535:1593:1594:1605:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3870:3871:3874:4051:4120:4250:4321:5007:6119:8957:10004:10848:11026:11232:11473:11657:11658:11914:12043:12048:12555:12679:12740:12895:13255:13439:13894:14096:14097:14659:21080:21451:21611:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: rings97_62f19680ca63d X-Filterd-Recvd-Size: 9697 Message-ID: <1493772678.22125.10.camel@perches.com> Subject: Re: [PATCH] staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed coding style issue From: Joe Perches To: Fabrizio Perria , gregkh@linuxfoundation.org, robsonde@gmail.com, arnd@arndb.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 02 May 2017 17:51:18 -0700 In-Reply-To: <1493771053-12119-1-git-send-email-fabrizio.perria@gmail.com> References: <1493771053-12119-1-git-send-email-fabrizio.perria@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-02 at 20:24 -0400, Fabrizio Perria wrote: > Fixed checkpatch.pl issue > ERROR: that open brace { should be on the previous line [] > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c [] > @@ -338,8 +338,7 @@ bool GetTs( > else > { > // In WMM case: we use 4 TID only > - if (!IsACValid(TID)) > - { > + if (!IsACValid(TID)) { > IEEE80211_DEBUG(IEEE80211_DL_ERR, " in %s(), TID(%d) is not valid\n", __func__, TID); > return false; > } Why fix only one of these? $ ./scripts/checkpatch.pl --show-types --strict --types=else_after_brace,open_brace,braces --terse \ -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:39: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:42: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:48: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:62: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:70: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:84: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:150: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:175: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:194: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:203: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:226: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:228: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:233: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:239: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:246: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:248: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:254: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:268: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:276: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:282: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:287: WARNING:BRACES: braces {} are not necessary for any arm of this statement drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:290: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:330: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:338: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:341: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:347: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:376: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:380: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:386: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:409: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:413: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:418: CHECK:BRACES: Unbalanced braces around else statement drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:442: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:460: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:468: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:477: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:482: WARNING:BRACES: braces {} are not necessary for single statement blocks drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:494: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:506: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:508: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:516: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:518: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:527: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:529: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:537: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:539: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:552: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:559: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:566: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:573: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:583: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:586: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:OPEN_BRACE: that open brace { should be on the previous line drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:592: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:598: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' total: 60 errors, 2 warnings, 3 checks, 600 lines checked