From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753932AbdECRTd (ORCPT <rfc822;w@1wt.eu>);
        Wed, 3 May 2017 13:19:33 -0400
Received: from mga01.intel.com ([192.55.52.88]:44783 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753720AbdECRT3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 May 2017 13:19:29 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,284,1491289200"; 
   d="scan'208";a="852506827"
Message-ID: <1493831962.30052.12.camel@linux.intel.com>
Subject: Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Date: Wed, 03 May 2017 20:19:22 +0300
In-Reply-To: <20170503170713.68820-1-andriy.shevchenko@linux.intel.com>
References: <20170503170713.68820-1-andriy.shevchenko@linux.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-05-03 at 20:07 +0300, Andy Shevchenko wrote:
> Instead of open coded variant use generic helper to convert UUID
> strings
> to binary format.

> @@ -677,12 +644,14 @@ static ssize_t remove_id_store(struct
> device_driver *driver, const char *buf,
>  {
>  	struct hv_driver *drv = drv_to_hv_drv(driver);
>  	struct vmbus_dynid *dynid, *n;
> 

> -	size_t retval = -ENODEV;
> 
> +	ssize_t retval;

Just noticed, I'm fixing a bug here as well.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy