From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbdECR6n (ORCPT ); Wed, 3 May 2017 13:58:43 -0400 Received: from mail-sn1nam01on0044.outbound.protection.outlook.com ([104.47.32.44]:44359 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753991AbdECR61 (ORCPT ); Wed, 3 May 2017 13:58:27 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1493834298.11226.40.camel@nxp.com> Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override From: Leonard Crestez To: Marek Vasut CC: Fabio Estevam , Sascha Hauer , Peter Chen , Anson Huang , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , linux-kernel , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Christoph Fritz , Shawn Guo Date: Wed, 3 May 2017 20:58:18 +0300 In-Reply-To: References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com> <1493141004.3557.8.camel@nxp.com> <20170503135715.GG18578@dragon> <76e22a7e-590f-00ee-04f8-87604303eaad@denx.de> <1493823533.11226.28.camel@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131383079044101157;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39450400003)(39400400002)(39380400002)(39410400002)(39850400002)(39860400002)(39840400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(377424004)(24454002)(377454003)(9170700003)(7416002)(356003)(104016004)(2870700001)(53936002)(39060400002)(4326008)(305945005)(54906002)(2906002)(106466001)(33646002)(6306002)(103116003)(50986999)(105606002)(498600001)(23676002)(76176999)(53546009)(5660300001)(8936002)(5820100001)(6916009)(189998001)(2950100002)(50226002)(81166006)(86362001)(8656002)(81156014)(93886004)(8676002)(966004)(47776003)(38730400002)(36756003)(110136004)(6246003)(50466002)(77096006)(85426001)(229853002)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0301MB0900;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD028;1:ClQzybCIyecWDEPeUMReVpVZ4PiVNRGtrnyz96UysTAD/E/qHJDv1/FF82k+elF63JqBwqw0ZUXKztwKbTZEKZNLW8CzeleIWJVhfDg3OtKoaN4X+ibbatiZ6bHF6hwtmFGY5mYaWTrUkwtooM/cABk8F2jZeXtZLuHhMXYNyqE7UhEI4X4DeFSH6HvBDfaCQALcmPpsFOM0EaB5yS+w4MMy4Zm41i5tIJ8vOZ8bBLXOfIpEWrG7jeE6SY4JFcSYie8qxGaAJTZaMMsDBSrL9lC5Vwmed+rihVlTfYtZEb1MKGi9MMC+2IKuTnAn6/ni2jmRJuXErp0pbtdmzgYrNM5BXV3dTmjgs6L139LOhKH9b6YvuiZHetYnWO1sH7wQnK0rQUs5sinImi2Mymsg5szzDgmFJFhlH/MaIu/c/P5MXCZPKHdAhPjGvIVA5/FFpU5QN1zLsMs+6+XLcpXaK8K4/sstwR2gjM+q0lOSrkf0ojtiUXK9MHNQ5OUoQPTAxmBt3ncQodYm+qMeC5ahGJN0XbYC447256J++5rfYq4jEJWUbHC8WDSfeFPNWwE0OqZlN8rxXD1kwg/MEXqb5x5ozQHvVbpokAj8N5z17qVmNmYZXVsEwzJHxs/l8STbNZJ+9Y+9saE7CundMACmHQ== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8d8eaa5-2397-49be-b425-08d4924dfe62 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BN3PR0301MB0900; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;3:Em8aqJvbAlVy9glTqSayaeQ+/6l+DdBrq/fV3o9QdaJAhhf2OfXpG4jdvYt8NMejPA+ttW8h6NNmd3hx9XuF8t99Gl8I/+M2bnoxNJghdyee1XTlPXpRB/OdfsVJ3tAjFGU2wgtqGGNkjR7OvpPNsT6YvT/CyDk7XaSSljrnoKTFFa9hceHVM4mDtIt1QHrYiIZdDw1aCACB1o7hvdxzfVSqEP5MVskos7f0RWc1wlswjc25SsCXO2JmX9zVUk5NDGkAl4KUNV1Ozo99eIraRvQAuZkXvDucdUNn+RbQ3eMMsLZ7PEw0XamBk2CdHextC58BW9lKfPNcIEivTlYNvoR2fhoZvDXS8kafAftlXnBHeDBhdjJc3DPbMP9mibGdlgkjX6u63Od5xaR3UL/wr4Cq2GX/SRfgNgkwISVB+pji9hORwJePZysGnS0/+JSm;25:Nukg0ho7tnetkO088i+wOVCx2IfbPp05f5GXcVaRsMEJqAQU7Tr3llK9S5Z+d6ef1t3cQYcVsi7AoE415RIEB7SoUIjH0uwvFyh34xS6xr8h9rNdI6y0a9lYl+CpOgV5unAjihXTea8IVZ04hAY/REi04SgTYVJPOeMNcGV0aAgDy10guCfU3uMFhg2D90z+w66c3aQpFAPXoMwTsY2KUDkNUNhdaB3UVaddqMvooPXYE0rVW9D33r19qO/x+b04OPuTjv+rd+U1zy8S+wWgMqBGrUY3Q7a8ZckUlWXCksipZc0xBUnfNM1blCnuOo+i5u0f74ZZYlKYjMYOecytuA5XNWvS/ZU0vFOdtOs9wp3t1GPXKe6FXt1Tnjz00MVeAgmfO3xiyH/vAgdQ+sZTaBLo3hmy+LzWBCr/2H5vIv4kWVaycvuLRveVLxynQtK/28dTDo3w1TUsCm7jC+w0og== X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;31:+CiTsrfm/IGadRZDeWlalFRivs89Lo9pEhmRAHAybR+oGUy2/onUaDM7tjOBqxipjUfWGuz+iMZFlJGsWnFK48BY1kT0ne3maJBsoRz0kK0QZPNwO3a/yK2AJy+4epnjIiIXbJmbV8ZwvV/QcTzlF0IGhXV5y8a3tX/BjE68rmdMszSo4ChfOh2J2UkRY5vNirbwc0wu++QmYgFPtICXZ3Yf8aLBvuUsk8iHqAwy/GeQNsmzae8oJhRHM/hKoIdtYa9IKBuKf+JGjuRghXaOE27e4sRS9avTBBSDEzHUfnE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(264314650089876); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13015025)(13017025)(8121501046)(5005006)(13024025)(13018025)(13023025)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123565025)(20161123559100)(20161123561025)(20161123556025);SRVR:BN3PR0301MB0900;BCL:0;PCL:0;RULEID:(400006);SRVR:BN3PR0301MB0900; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzMDFNQjA5MDA7NDpObTFkQytyb0x6NkhFR3dmR2oxa0taamNm?= =?utf-8?B?NUdZZ1NmY09JbTZKN0k3YmgrQlN5aGtHN3o4a0FhZWVQRFNHT083MUhqOTRz?= =?utf-8?B?aitVdU8vNURVOE9JcGROTS9xSWY4aCtneXRpRzFBaitLWDRLdnRsK1cvU2o0?= =?utf-8?B?VDhEWjZRMUd6c0RpQncxZkJiTDBtR0VlYzdqT0NvVVNjOVMxK3RGRFJQNkZp?= =?utf-8?B?UUtTODd1NEl3RnZRMHZSQmdlNWFheFBVbjZYOFliSjRIOXlPMVZWQUZEWnJJ?= =?utf-8?B?akY2d2hyZ005V3ByR0QxVjZwMFU1SmZiMTNQQXJMZnI5QjVjUGYyb01sYlV1?= =?utf-8?B?OW0vZjlwZzEvd0l5Z1ZNYkRlbUczbDF5dmo3bjNXM1h0VVMzajdxNjNmZ2dO?= =?utf-8?B?WmorQTkzUm5LWXVXOFBuM0FZM0l4OWJyWTZRZXh0VHI4QWowNUxpUkNQRnhu?= =?utf-8?B?VTVvdndwSWk4TDBBU3J4Q09kUHRxUTlKQ3BGazFFUTdLdC9ENW82SGJWb2dL?= =?utf-8?B?TlBZaWZXTm9FbFJrMHp4ZFE5QXp4RnhKV1hyc21WQlFoaVBNNHhKZm1jZXJR?= =?utf-8?B?V21ZN08wcnphSzdUQ0N1R1VnaWJaQ0VEeFBwZFZtSmRZYThMaUZnZEhKc0NC?= =?utf-8?B?NHEvQWQ2K2FjanJmOTVQNXllakJwOERnUjNDY2V4SGhtWWsxQmxuRC9YVWJ4?= =?utf-8?B?Yld0YnFZSWd0TEFBQ3hNSjgyMVE4N2RDdGVYKy9lS3hUQW9tVUZFcVNQVFg4?= =?utf-8?B?VWhKZ2RCMUtlcTRINWd6M3FyVnk1OEkrMVZVK2Jnenc3RFFqS1E5ODBrNGJT?= =?utf-8?B?ZFdqbEpIY0tLeTJ5cS9KQWNZSlpBSU80S3RxREN2WGxrMXNCZjZvR2gwNDI5?= =?utf-8?B?WS9lUGFBL0ludjZYRXJrSjUrR0h5R2dCb3ZuL0Z6cDBZc0lhU1I2SjFTb2ZL?= =?utf-8?B?MUIxeDFONjNic1NwZFg1UFY4QmFKSFc3cFRLY2RRcWRPeVFzcTB2ZTFqdjBi?= =?utf-8?B?STg2ODNsZjlNREdLTjRIbndNeUhJbE9DTkUyUkNNMHBQR0dKL1NZbjdFZzJw?= =?utf-8?B?UERmWVBVc0h2MGxCclRVY3orZFA2WVROZTd0UzRPVnoyWnVHRkp1dVFTeS8r?= =?utf-8?B?SEI2QUg1QmQzSFQvMHMrdHBYck5mOWQzeER4T1ZoRnlHdVpTY2hHdXJERjBZ?= =?utf-8?B?UEhIOUl0U2V5SjE3RUVZRHYvYXVMQmNaWnVhcmNDSGlENVdYQkVodVl5N0Er?= =?utf-8?B?WE56TEFhVmhkVWk0ZUJyUXFJWGNyOVhDc01SOGZwZ1llZFkxQ2ZNbVJDbWg3?= =?utf-8?Q?EW7mG29kq5rCPUNe9V5Gq9wD1ST1tGy4I=3D?= X-Forefront-PRVS: 029651C7A1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzMDFNQjA5MDA7MjM6d1hDS2VyTTUxc1VNaHJuUytJVVV5U3pE?= =?utf-8?B?bmJBTjZzSzBvREFNSWdINW1CaWNSUUR2WXJoQzBDQVkxZ3BldWt0MVAxQU03?= =?utf-8?B?a202YkROckpOMUlVOUJiY3BlSWZ2OXhOY2pQZlNrU0tBaW0waWdxYU1JRmNR?= =?utf-8?B?YW11alVOUFVqN210VVpiYXFTd3d4ZVhMek5MSzViVmNsWUV6eis1d2xSelhP?= =?utf-8?B?Qzc4a2VnZkJFU0FTZXdaV0VucVc1dzRWeGI4NHFnN3RpYUxzZnNSTlVMbU1X?= =?utf-8?B?RWxjUnFzS1F2R0l0RE53QW0vd24zZkNSeHhmdjRrM3pBK2NmakVtaXlLZUlL?= =?utf-8?B?ZElDK3R4ckJMbFV2YzMxbndFZ1hlZHloN0VhUFZockhhZ0p2R29CemVpRE82?= =?utf-8?B?Zm1CLzlTa3BtUXB0aWc1TTN4MW5yKzBlbXhBZXFHYTRGL3pONGdZSnVPcFJC?= =?utf-8?B?eGQrcGdXNE91YjBZMVNzS3JBN3BJb3A1dHluNk1hajZsWlRwbnRrdXMrZjNU?= =?utf-8?B?czdEMmxUaG03UEZYNDdNOVhLYTJYbmZYQkpES0s5R2hvcWI0bFdXSUpNbWFs?= =?utf-8?B?aVAvaDl1bWVEc0JDak40Zk1wMGkvTnNOODJ3QTV6N2pETG5oTms1cmdlT1N5?= =?utf-8?B?TW51QzBlWlpNMm9QOHltcUR3blNOV1RVdFVZUWptNFYvQlJHQTJwT3FFOTBx?= =?utf-8?B?NG1VazlHM294OHpYWDFlVE9NT0tJeVJ0WmVxb0JJRVp0b3FJQXFuSWxmZUR6?= =?utf-8?B?WEpDWGxvRWZqQ251Wk9IdHl6d2xtaWV4UU1KWTBwQW1Zd2ZSaUV2Wm56cWpV?= =?utf-8?B?bmdFdG9LOWUrekprV1Q1Y2ZiNlltcG5kYkt5bjNvNzJ3MVFZM2xBSVpQQUoy?= =?utf-8?B?cXpYOHRudkZmbTBFVmVuOHVFQWdicXU0a2o5ZlBKbDdQUldjbUEyY3ZReGZN?= =?utf-8?B?aVA2TFBzMldzcG84SXJFZWdGUk0vVHVpUWtXbTNiNzR3N2RTdkxxQXdsUC8y?= =?utf-8?B?azRNcWltRjZMaUllMHIwQ2NQdGhZUHFSSzJNakxBVDhjRk5pVS9UYW1Ud2Y5?= =?utf-8?B?VHlGVkc0RHpVYzZXbE4xWDRIL0tvdFRyMUVVYWxrRTJ1eGtJZnRQcDhONTlj?= =?utf-8?B?elp2Tzl3d25nN21sN2ExbnRGOWNwK2N5cDRIMGVVTnpoaXlDTTZqOGoxRHph?= =?utf-8?B?c2pKZ1ZLaDBINUZ1b0xMVTlWVjNqellYYmlpR0F4ajRWcDBSQWRIS2Uzb1A1?= =?utf-8?B?TFVOa2gvYnpHMURReXUrSG1qbnY4QUtLdDNzZ0hFRS91RjlHTlFUbzR6bDZj?= =?utf-8?B?NlpvbnFBL3QvdFBwRkZhTVdVbGd2ZVpIOEI1RVNyaHpHR1NlVDd3UGFySVVh?= =?utf-8?B?czR4Z0NNdmJXNFBYWk9rd3N2U3BoT091Rm5yM0tzdjNTR000dUUwMG5SWFUx?= =?utf-8?B?andzOEZ1cFptMHNVeWVOR1FNcFhrWVlmV0hKd3lWMzVONWh3d0dvN092S3Jw?= =?utf-8?B?NWpQQ2x1UVNZQ1RnaWNJRkM4bk5zQlBxdm1IVXkrUDdLRVVPSTdoQzVSWlcr?= =?utf-8?B?blY3LzlKaHFuMms0WHZmc0N3TWRqdGZ0VnJXZkN6Q09zWTVmTDJpT2NqQVpV?= =?utf-8?B?N2VWZjV2aVVCK3VoVjdETnN0WkwzSS9yQUxyMmo4YXI5elpndkNRYnJ2WGk2?= =?utf-8?B?SGhLdkViY3dmWnJJbUR5c3BhaVRRa29tNVpoVnV4clRrR2RHN1o4N3J1WHB6?= =?utf-8?B?NHI1UW9ERi9nVlJrRHh4eUNFQTY4c0t2UVlHTU1wNUxtYkE3R2VMRzBlUWdH?= =?utf-8?B?OTV6TnVFVjBDY0M0QXo3UWVPWE5Kd290UU9VVXk0NTNTcVNmZ1FIdlE3UFg0?= =?utf-8?B?aWduV1RocytNQllaa3p2aTlmZEhQQzA4dTJYbWp3Q0xIVDZDTEdIVWVvelZB?= =?utf-8?B?TU9RWXFETk92djhDL1puZWh2Rk1sa1RRcG1ra1BvcTRmRWhNemtQa3NrTEN6?= =?utf-8?B?U1NJbGFreTZEUHdpU2kyNkdYRXpJck4zSlF1dTF4dDU4aE1tVnBPQnh5SktG?= =?utf-8?B?eDFWNUlqRlcyUHExV1ZIZHQ0TXQ2VTJXZ1JjNWhFMjlaRzBMT05oT1JoV1lk?= =?utf-8?B?TDZ1dz09?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;6:amg68k76qZFOgnUn6uupxEoase4jLupP/6qT8ZdTw4yTMKTvEP/MaQ/dSDKJ/0BrC68FKZbg+y3B++/Z8rMFB12EcZrcsIQ3NvpRAYnTNVbsMUE/e7FiLQZpsQP4HMLBdhqmUeMOVpyt7LVdY/KIU8H1LzLXEYyJEVAaC37CBKoQWoHWcqHvfmfSOWigdO6KRSf35eNvhUwgeJl0TpIOfFk8Mr/QMCNVGX46PDeR6yJYjHWYpP6dFRma6aIqJDgfZyu90lGUVT5X/TQk93/d1vpe5k+ZRD3IJ6GRI2e/GLIc/4jqe5vy25ipjq4IhcC1W3Ywol6pBaZj7TJO39ZMZdF3ELKJrYRhnOdBr4UzVJLmbiy6GmPvY4S+5Nb/DPymqlR/kHoaq6gjf3hi+kbGDn4qhJq3N17j78dKY7PVA3iDLpxcSWjLjDjqeIXmTX/+6hjzQsLWGN8gPcEu39PDXQfbi3GMmWdVy54I1mFOP86uXTYZ1Iq9WqQJnCbjSCovxZRV2//4cbw1IXmRwI5W0g==;5:MO6WkQ3KK9nMHood69kkCHfklwVhjU5LJL/EKvM2X+Yn16jEOXrUsD66Bhf9xW4vFBeKx3OGXW2QuY6DuVPiMsiYPP2tQDEI8LdSzpg5cxhGTQcuC7lfjIlz3ejC9ZuJQSfJ3aLckBweW4kSKRXWHSquvbBFZGs6+QlrpXxRVXi6whDqz24XAanN0m1SRdKS;24:HGYfGKlk98x1ns71nm6xXLN+JC6ZjpDuwHGq9GzDUCGr9+dWZaBzr8fFfHkO2RGHt7Ei3laf4z0OQ8+sy4+G+ycrRywSwPmPvTpzSMRJOY4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;7:WtzbAL78C1ce9yOmE/l6YQTtergpCGiEjZ2hh5hKXna0W6S5EV9PyI5iC6Kv6nVJJgorSL+zBSmi8R7MF+fPJ+fv7Nd2D9UK3v/3Psk2xSHYYn801WTGGuECA9LG/aRKWzaOVHAV3ymCmt/0Rz56+P2L0VzCiDykD5DlI5oEmSoOwXeCbnkQs41s/fa4jOUzxLTKItFlXwmVKnpyp/jB/Dype+utPkCnhSRv8f/AO56s6pbO7EqadSr8T0/X1ZBQ3wbnadpPWInv9nqxvdaXxOnR3hfyArQr8dIB31y7RXfxJrZmzwIuNQBGFJxw420yUYEfK2IkiPfQpV3knziYwQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2017 17:58:24.1917 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0900 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-03 at 17:59 +0200, Marek Vasut wrote: > On 05/03/2017 04:58 PM, Leonard Crestez wrote: > > On Wed, 2017-05-03 at 16:26 +0200, Marek Vasut wrote: > > > 2) It actually fixes a problem with the voltage rails such that the DVFS > > >    works without leaving the system in unstable or dead state. You do > > >    need the second part of my patch if you drop the OPP hackery, without > > >    it the power framework cannot correctly configure the core voltages, > > >    so the patch from Leonard makes things worse. > > No, I think there is a misunderstanding here. The second part of your > > patch will cause cpufreq poking at LDOs to indirectly adjust the input > > from the PMIC to the minimum required (this is LDO target + > > min_dropout_uv). Without it by default VDD_ARM_SOC_IN will remain fixed > > as 1375mV from boot. > Who sets / guarantees that default value for ARM and SOC rails ? I think it's from the PMIC hardware itself (but maybe uboot plays with it). VDD_ARM_SOC_IN on this board is tied to SW1AB from MMPF0200: http://www.nxp.com/assets/documents/data/en/data-sheets/MMPF0200.pdf It seems reasonable to rely on such voltages set externally. > With the OPP override in place, there's at least the guarantee that both > rails will have the same voltage requirement. If you remove the OPP > override without modeling the actual regulator wiring, the guarantee is > gone. The imx6sx chip has internal LDO_ARM and LDO_SOC regulators which can generate separate voltages for arm/soc. The fact that these regulators share the same supply is only an issue when they are set in bypass mode. However the boot issues happen on REV C but apparently not REV B of the board. I don't have a good explanation for this so maybe I am missing something. --  Regards, Leonard