From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbdECSYB (ORCPT ); Wed, 3 May 2017 14:24:01 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:5323 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbdECSXx (ORCPT ); Wed, 3 May 2017 14:23:53 -0400 X-IronPort-AV: E=Sophos;i="5.38,284,1491235200"; d="scan'208";a="15026120" From: Bart Van Assche To: "thierry.escande@collabora.com" , "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sd: Ignore sync cache failures when not supported Thread-Topic: [PATCH] sd: Ignore sync cache failures when not supported Thread-Index: AQHSnnVPIfFEAhoqTEygu+twkZV/iaHjN+aA Date: Wed, 3 May 2017 18:23:50 +0000 Message-ID: <1493835829.3901.30.camel@sandisk.com> References: <1489682932-18543-1-git-send-email-thierry.escande@collabora.com> In-Reply-To: <1489682932-18543-1-git-send-email-thierry.escande@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: collabora.com; dkim=none (message not signed) header.d=none;collabora.com; dmarc=none action=none header.from=sandisk.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;7:bUjcVRAaubFDQGDfjUPiVGErgyCYH86eX7U5kuYQr2uWos8mLofw8tXp0TxKeB5OHg7MDLBF5hNMWnbKvxrFdp/VmZE0FnqUlgzcXDIGT6O+KOFpviFZxeneaigx51s8uGqEwsEQgYN4iaLoG6PDywCexm8pb45m/ybV2LWnPF1gNY14+TdR7meudEUADfWpe+JcI1IWkjz06oK0POFPKDlWBsfhRCX/RwztxC8zzYVl/Gc1DA4MnwD92qdqGpBwjsGgMghd7IpwAbraXkU/avQrNUBJWBd07D8ucVjBCg/gPsMMgXND9MmVB7JoW8+axpBQCzx6lafO+K/q/kBf0w==;20:CvElYxJv/089gQrAf47BDxC29G90FjHpWBYmmwgaPUtTsY7yooCG7PrBZBZ0wpZPmgMJBcG02AScQD8T0+Ig7faVgxGljQ7YGMUOmHfnT3f447TQ5CcHvfKn4PHuPUHoukZMuovIcIIIAJrFDXYPoP3IACUYEMHnmhz/N7Gg/c8= x-ms-office365-filtering-correlation-id: 71d06165-3315-4277-ab9a-08d492518c29 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1533; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(6072148);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1533; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39860400002)(39450400003)(39850400002)(39410400002)(39400400002)(24454002)(377424004)(501624003)(5660300001)(54356999)(478600001)(36756003)(2900100001)(6246003)(38730400002)(81166006)(2950100002)(3846002)(305945005)(102836003)(103116003)(53936002)(33646002)(7736002)(3280700002)(6116002)(122556002)(25786009)(8936002)(8676002)(3660700001)(50986999)(76176999)(6512007)(4326008)(2201001)(6506006)(99286003)(6486002)(86362001)(77096006)(54906002)(6436002)(189998001)(229853002)(2501003)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <748C042113BDE1409064D3F08D88E9DA@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2017 18:23:50.5129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v43IOH4x005172 On Thu, 2017-03-16 at 17:48 +0100, Thierry Escande wrote: > -static int sd_sync_cache(struct scsi_disk *sdkp) > +static int sd_sync_cache(struct scsi_disk *sdkp, int *sense_key) > { > int retries, res; > struct scsi_device *sdp = sdkp->device; Hello Thierry, Both in the SCSI spec and in struct scsi_sense_hdr sense keys are declared as eight bit values. So I would appreciate if the sense_key data type would be changed from "int" into "u8". Otherwise this patch looks fine to me. Thanks, Bart.