From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbdEDJml (ORCPT ); Thu, 4 May 2017 05:42:41 -0400 Received: from mail-sn1nam01on0055.outbound.protection.outlook.com ([104.47.32.55]:40171 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751825AbdEDJmb (ORCPT ); Thu, 4 May 2017 05:42:31 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1493890943.11226.42.camel@nxp.com> Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override From: Leonard Crestez To: Marek Vasut CC: Peter Chen , Anson Huang , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , linux-kernel , Christoph Fritz , Sascha Hauer , "Fabio Estevam" , Shawn Guo , "Fabio Estevam" , "linux-arm-kernel@lists.infradead.org" Date: Thu, 4 May 2017 12:42:23 +0300 In-Reply-To: <51fb1bd0-028d-c431-acc8-3c4f1d25fdba@denx.de> References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com> <1493141004.3557.8.camel@nxp.com> <20170503135715.GG18578@dragon> <76e22a7e-590f-00ee-04f8-87604303eaad@denx.de> <1493823533.11226.28.camel@nxp.com> <1493834298.11226.40.camel@nxp.com> <51fb1bd0-028d-c431-acc8-3c4f1d25fdba@denx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131383645499066952;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39840400002)(39450400003)(39860400002)(39850400002)(39400400002)(39380400002)(39410400002)(2980300002)(1110001)(1109001)(339900001)(189002)(377454003)(24454002)(377424004)(199003)(9170700003)(53546009)(36756003)(23676002)(103116003)(76176999)(93886004)(305945005)(50226002)(7416002)(8936002)(47776003)(39060400002)(6246003)(50986999)(189998001)(4326008)(50466002)(81166006)(5820100001)(105606002)(33646002)(498600001)(966004)(6306002)(8656002)(104016004)(54906002)(38730400002)(85426001)(77096006)(53936002)(356003)(8676002)(110136004)(2906002)(2870700001)(106466001)(229853002)(86362001)(5660300001)(2950100002)(6916009)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR03MB2786;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD043;1:Rgbb3OICp+nf6bT2ybajgkRYth2PCOolto990lPkLwH0Ww8f7mQGKrtA7cQbFQC8ypi1/tsT2g+Ac/3POQlTMHs1sI/UFjKDpfEF6H76uxF1vLRCfZ1j2sQ6FmhxIWTxKjgZRVrCmvLTI0rVUr4eTVXBer1Wal16RJqhUwfMpLyMxeuqbutwzVai+QjW4Vr956rB2s1Ln983OyKLLBuRejkbmrJvVwumrbISNvmNQgId6Dbwv8KyFAVQp/v+OUYXbq8sm9OkhSWCMILYYH9SXLaYFKvVSkSECDDRpHnis3IfsINspeskYjwT1qTC96Qll/4bfG9uq3ed+cCDJ8d9nRJfUv9TzYkabZDK06k4CvckW8UP5KKUCijhmc/InDob07pC98QluLpFlojQRhb1+CVZwTmPc/jxETp87D1ONVCK7qpI3gcYDIhHzpogZgHP153jR36rancSG+GEjv0xOOzYWWlrHa5ldxem7CzgFmgGa/SkdKJpDkqeOdtxtPiVE9GP128CFXfseorUgPArG4+0hah6iosNB6mJ5UqicatLXj2xZMabgU0+WwRwVlzpjXDam06tDjkDLlHRhDj3VbSSK+xAHnfygdFQZYX/jhP7gPklqgRP1MaXtnfXCJuTDxLex44h5SH6dIW1eB0/mw== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7f4361d-438a-4b88-1dd6-08d492d1e1a6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BN6PR03MB2786; X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2786;3:K4eTSX1Uo03XTHLXAT9/Cl9zTbBFsaIRVnG1okpIqOaMXzk27ubFexfHBgd/D6/YUzUpgB+lfOElNNayoVPTLrXacrBT1ktnNTccekjkNXBy7hgKPu+NcrAsAfMvCny+bcjJ212hstIN5BObi4uXGz4hLUw/91g8UA2EgW2dfUEIZGY7GQRAA/9vCVIRiMnAxgKsDad22v9cXpJtP78gxIQYRk0rs0D6HMeOaa7gdWugq/zfiKQnrZCTf4lJm48LDuxgVsvsxRO6tAIMfiISQIOLXd9gzyGQ5HGTRw+Vz4EfNZcnn+VvrmtVBJ2D4F3n9FgwmD0x0VU+rDON5a5myYqiMo/eOvunUcl8Pbcp39IuIfSQniU88c+P0xPNkQLPOLBXypzaD1scrTgclUfrmCwtgQt7yQlz/3U89o8UEySuF9HFN9eQ+aLUuezhcpPE;25:99ekPF3eJUK9MYt+JhNw/wNcE3GWZ6abvKgHpGD/14QHLwo9FVx49LYYh7Ofi7fgnivlTFwaNDzkqqMDwkN9y4RDWJaPv1lWjsttyXltivPNsf4HMDLPs23eV3BC+LbPVZgIYKVEIfY6mN4WwWXInzPWXaf2T+oAMie7qy95KzSwkJX+zd/s+Fb9lcX5Ib1ePXWWley7ml14aCy3+4XS/7w4i9BSAJv1rN6CD2OERmyqHdV2qKSWTwwwrWSVZf/Um+0aL2nj+NrM5ZroBeQ5HC7i/Qw4t0t+BFDGHpB5cibGgtYD+/hFyv6V+9+AA/VWNepyPoovy2ASGIVijOuT0jkkyG373rSfQHm622nODLIyxr5sH2qk5QTceUyNCcylRS7smlmXQl3Ea/GO0LNy097sFzn6a17jLFFzne2E4vl74J+rQ8Gn6IRhAZ/5MYVin/VfSoT9hSllKdVME56z6w== X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2786;31:M3Zji/hFq2cv75KOqlYGXbZQkJQ8ue33Q2sRCln48jXVk/d+mCdifejXIA04ZCGTamp2DICvHWmX0yXTO1rQNAguFqKMlvp2CGZCldBY9V5n7bcuBNYOkNM/R86PKXLn5F2x3A9/m5T8G9Ug7UZAjFb9vy6KZTQAUDoS8cHm8phpmtbbtcQqfEZ9YM8zQMgOsXAiw+Lrmd8eb7y6UmMLyR14/o7/5qEK2A9r+NS1wocqnN9jCKwTPO7KXDI50Opw/8jLL0ef7VFuPjJGxIp3POsteUXVuLvU2RgF0cTx9mI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(264314650089876); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13017025)(13015025)(8121501046)(5005006)(13023025)(13024025)(13018025)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123561025)(20161123556025)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150);SRVR:BN6PR03MB2786;BCL:0;PCL:0;RULEID:(400006);SRVR:BN6PR03MB2786; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNzg2OzQ6MnZWL3NJb2hYcDFDR3lNckIyTFJDc0JXRVlB?= =?utf-8?B?eGZiMER0L1pTR1ZkNU5aUVM1Zy9VeWovUXFXSWs5TUxPUS9xenJXRGlZbysy?= =?utf-8?B?S3BFT0NsVDZvSVRjTEw1R2FRblUzZVVmenNWNFlNK2ZuOFY1NERHc1A1VkRi?= =?utf-8?B?UjZ5SitQTjJzZHdFRlluL0FJK3FtU0xzckhxR01SeGVjbXBNS3BUYzJJcTl2?= =?utf-8?B?WmQzSVg3VTU3N2VVRzNXQTBiZUZld09OclhJWmV0ZnJGVzdkRmtTODdKS3BD?= =?utf-8?B?NGFIQmV2dWVXZ2psQmI3VEZUNzZFSEZHZ1ZhK2pUVGFJN0U2L09lUFlKSHdq?= =?utf-8?B?NDZHRkY2aVFLaFNHeU9nMW5SazJ3ZDhLREhDVTNBdWkrOUtEZkdnZlR0eW9E?= =?utf-8?B?LzVYT1FXQ0lWN1Q5YVJQS3NzUk1KSVdpOTRIemphL3RZczVNTlNNWEg5dkgy?= =?utf-8?B?UFJKbDR0T0Urc1BXSzNMemdoZUpxSHNxNFlnRjFDV0s3Tk5HY0xBdG0xKytS?= =?utf-8?B?b0cxb2svTUk5OXoxQTRmWkl4akJNNW1VVE1kd3hyREdnYWt0dXQ2ckowRWJ4?= =?utf-8?B?TzlVcVJVeUxPQ09TK2JFVnU5T0d0Tm94TDF6bTQ5cWM3RmJLN242SWF2aWd1?= =?utf-8?B?MG5LVTFzNlJieVFvRjd1TmZUUjBhQWF3bmN3bFkzc1pNZzZrcG1sMjlXM1ZP?= =?utf-8?B?bGdwTlk4amJzcGdPcXExeVRvd1BMaDNEdThHdk14aGZIZ0QzNEh1U3BUT3pP?= =?utf-8?B?MVFvcWgrMU1tSElKaEFyZUU2aXAxNzhCTUJBUnIrMUFKN1M2TDE1VjZEN0s2?= =?utf-8?B?YnhiSGpqZVZTdnBGUjBod3hGVHRJekdwS0hGUXMrSVdSZUVIcXZMeGtoZm9v?= =?utf-8?B?TTM5TWh6NDY4bUJ5T2dJUlZIVHFUdWl2RTRxd1V6UUFnTnAvKzNKVWdpUDFa?= =?utf-8?B?U2NyRnZQelA2WWp5alRxNS9WeWRhcVhIeThvWVU0b3ZDcjc2aUVEaURZODYx?= =?utf-8?B?djF2SWZIVU5oejlxTFYyZG1SZmFvSzlLZUVyU1NOdHhWaEZzbDV2bS9PK0RD?= =?utf-8?B?bDNnOXc3djNSTmFqemFCYVlxdm9PbTNIektXV0R4eVJKUjRtdktxT2tHOWpS?= =?utf-8?B?UW9ETUlQb2NWSzFDSThHR3JDVTVxK3E5NlBOWnRFa0s2cjVjUFBVRUtKY3Fn?= =?utf-8?B?cG5hR2RycFREc1FRWUVVcnlBemh6ejI2ZXJScmhXclIxY013UEwyWWpPUHdH?= =?utf-8?B?Tzk3OHVZQlJNWnRoelhoOFhxcUI0TERLU2pMN0ZvcWhLZGJtWFpsMG9Vby85?= =?utf-8?B?M1VpZ3BBa3IxQT09?= X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNzg2OzIzOmN2dEpLL3dmRE5UajNSRng3VFFYbzNwdisz?= =?utf-8?B?SGZsY1g1ZjltYk5tZTlzdUgyV3FTaEV4VnRWbGpvYTVSSU9YRC9ReGxBczZW?= =?utf-8?B?amh0eUo3alFMWU53RjliOTlicGYxQmFDQkJ2ZFo0ZEh5a2dTMXNrNHNkMTA2?= =?utf-8?B?cm1qZURlWm4wMGtpOFhLdHRXSUdBYzFOZWZjMkJTR0VzU1dxRXM4YUErSVh4?= =?utf-8?B?UW8vN0hsSjVrRTI3SytpSTcyR29BazFENjFSMHpzdGZqREU5QnJRYkdJayt1?= =?utf-8?B?V2UrNGovbnEvVXFIZm0rdko5azBsTHExYVlYc1ljS1phMGhUcThNT3pJclVZ?= =?utf-8?B?dnNiOFZvU2kwR1VranBvU3RucGNERmpqekZuVU5nUnpGRDdaVjNWQ29YMVRB?= =?utf-8?B?a2tkQzB4R1JCSVdkZ2piUE42a2VpWlkranhVRzJieUNqVy83ODNvaDhTWWJs?= =?utf-8?B?VE4xYnhONzFSeTdhZUorK1dqMlpKSFR3WWFCRjVGT1lMLzRUSlB1WTh5Y1Jy?= =?utf-8?B?RzBibnNkWXdhZGhGR3dzWllVWFB3amVNLzI5aHlNWmc5TFBRalEwcHlzWHp0?= =?utf-8?B?R1p0cWlOUTh4ZndKcHRZYS8yWTErbWszSXNzc05VSlI3dXJyZ0dwem5lbDlj?= =?utf-8?B?OHAzaGJvQkdnV1pmMi9MZFZ3TXd0YkNoZGZteC9PWUMwZXZuQ0d6ZmVjanA2?= =?utf-8?B?RXhEN2F5Q3VLcG14dXpWRXc3ODAwZlZ6TTJ6MERaNS8xS2UwWlZpRHpkK3Qw?= =?utf-8?B?N28zYzhzdlFuNFJmTWJTd0VzZFVYRmxNajN3R3Z1NlFtMHVQMXRmWUVZSTI4?= =?utf-8?B?WlF4bjhmYWt3cmpPckF2RTlqKzcvNkpvT0RlSU1nWXFPZlcrSFVpTk1FNXpu?= =?utf-8?B?dzVLc21yVFA0WGE3aGd3bEkrNlVhbGhETmdVK1ptREFFRlBqYml2R2s2ckhC?= =?utf-8?B?UnhnZmMreVhGWEgyaDByY2ZoOWIydlNubnYwa2lTYjNwU282Ri96M3Yvazd4?= =?utf-8?B?Yks1Z3pNdWlXZXdSWVc4T0hOODQ2M0xPRFlQWEtqbzhZbWxlaGJPcjk4S0Jy?= =?utf-8?B?a0RsZENtdnZ2WmY3ZzR4T1BMaXNCK09UdGVuV0RLMGxRdUdnOWE1ZDJ4aEtK?= =?utf-8?B?akpYT29FUFFvRGtWVE42RmFjMlVmQVhsdHZsRTFOblovUmlBdFVjdGtRSmV3?= =?utf-8?B?WFpnUmF3ZXY2RXFuSTVMUjF5Qmo2aHZPWlhBZXZMdUVJNmE0bHd2SUxycDRv?= =?utf-8?B?eExlVUZzTGdLdkdzMVlMS2J4c1lqcTNDdERBQzJHeEtUbHBZTEVOL2lwLytw?= =?utf-8?B?c21FOVNHVnBwVmtPcDA2eHdSV01YMnpUdkNjbDBURkFuYTQySTJmTUNENWgx?= =?utf-8?B?N2Y3NXdXMUR3cURWajJibWFWUjI4SC9SbmV0VkJOMlpVQzEyM3BqQWFqblhy?= =?utf-8?B?dUFnWU1icXZ6eEh3NEJrZm1ZdDFHL3A3UitBNHRmT2dZeUtBMWc4ZkJxMk9Z?= =?utf-8?B?dFpGU21aZ2g2TXQ2S3gxM3J4SzZrdzZGS25iazFSalNzNHRUZVVQdEtNRXBm?= =?utf-8?B?cGpSK3hnWHhwc0RqZXVPbmNQV0x3UTN0MWg4UVJ3T3F6OVJ5d29oeU9DTUky?= =?utf-8?B?dlU3aDBHRGp4SUlhYkJYdEZGUXRoRHZVWmUwZDZTQWRJNDVndkt4V1crSS9y?= =?utf-8?B?VmN6NlhNNlRjSTFscDduNTdYcm5DT3dneWdmMlFibDdIbjZlQVhOeEtxdDhs?= =?utf-8?B?aTNCZGZjVmt5bVppLzdsYVpTMFgwT0t0TkRuQnVqUGFJZURlK25BUXdZdFRm?= =?utf-8?B?ZUxPVE10TmlGaHRQSFZNUWp0dE5nc25hWnI3b0NrVDBsdStTejJNZm1RYi9R?= =?utf-8?B?ZmthQzJqdVNVYUwxMUpDTmJGcHhWL3ZYazBYb0ZyL3p1TGI0YTZOU01LMlkr?= =?utf-8?B?TmhnYXNIcjRrWTdkVnBVNi9XWWRQdElGLzdEZU5WUFRvL3gzWi9Cb1lVM1F2?= =?utf-8?B?OGJHUEUvZi9ieGhhOXZCNEp4RmNMWDFLRjNzWktQQlpJdlRjaWlrRDduOUx6?= =?utf-8?Q?saw/Mik8APqCwV82+YY330B5h?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2786;6:IQG6cbtR11RFM9H6D2cn8b0n0JpUxuoJ3nSooyM0AgHxlH7/x1PW8V+MS5LplLIHX9JkGkfrJRThLKH3ook6VTG9oQSfSD1MLUlD6m2kfFPhZrCZWylwbrwTI0xMkxraRJq0DxnDpimM0/vPprR6glKZ+mt2o5K7FNOkJFN9DwhDR5D2rL+i1UnK3QsV7XLzo/Dck7jNSChQssf1WG5dHALsJYy5LBx2WrVEQUpKLtP7XrJtx+s0VxlYEct57cDNpbwKlNHEuSu7BRiTCpftgR4UsKsZweRwwml5HzPHHC76ZV28HeSXuR8pWcstxjWm9EDzIwHTxd1LdmqGUd3xdpzflgnE9BLJy0xBYPSaDe2psxcS6Wd/Dg9Ef76ZzvCpyv0IZup/AW4cg5egXyBFq2LSa1IcTAoMEQp6bvkpm5itzwYJTaSpjoqut1V8LMRK95JhYau9pp0ZCzFFgukJj/IXNgYIsAktlC//D7ma5iovN6RL9QPJWT2Hu73/rAj7;5:jAf2FbirK7oy/Z7cjEnUNI+0+EXEFzZwoJMawU0hUKPoH8LqzRwkQhrn8H3beiMDxRtQPOqmHTqUuoB0E/adeNtd2oXrmZjOdyYfDXTRhJxWyj3r1GqiFHHKYTyx5Ho0Z0693GdZ4Gk35CcYZ/9UexBg+xn7NBdiF+vG1285Uijj2F1s6sTspmWcGtqlqyse;24:CBPQ5vVGxLzeYdWLzAe6poHRiEctTEFODlc8w2xG8guwcScbTlekCUiYJ8XnF0xZoTfrNcmaQKveUt1iof/BuNxT+ZZsTQ7y9N2+OJczcag= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR03MB2786;7:ebjlPmQVOxpuWsPxSIyRaspn2i4sUfcvUW0K1skzFFp/LwqdWZFr6d862/5CCqc0ydsQY8HSLQ1cYXoyQZanvNz1RSxpANa/osEqMpHWhsgiBA4JY2ORIcqgGyu7cv8maUeXFAht0jp7gDqjA7K1I3i6EQbmg+NCcOXW+pH9urd1mBxsQrE+GmA3xfSXotbsaAKahx8pi/MeGYy5bAAI6sWsadEl1VxcG24IRxymUFDG99wwDqbfbf9NW3+pPOL3woIDqZELK7ASNlwtFdZxJvrRcMIsurd29CQsLRic4KnIsTKZQZnYdMf8VzCghsNcdKmvxkUivPR8hv+kbAiRTQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 09:42:29.5634 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2786 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-03 at 21:33 +0200, Marek Vasut wrote: > On 05/03/2017 07:58 PM, Leonard Crestez wrote: > > On Wed, 2017-05-03 at 17:59 +0200, Marek Vasut wrote: > > > On 05/03/2017 04:58 PM, Leonard Crestez wrote: > > > > On Wed, 2017-05-03 at 16:26 +0200, Marek Vasut wrote: > > > > > 2) It actually fixes a problem with the voltage rails such that the DVFS > > > > >   works without leaving the system in unstable or dead state. You do > > > > >   need the second part of my patch if you drop the OPP hackery, without > > > > >   it the power framework cannot correctly configure the core voltages, > > > > >   so the patch from Leonard makes things worse. > > > > No, I think there is a misunderstanding here. The second part of your > > > > patch will cause cpufreq poking at LDOs to indirectly adjust the input > > > > from the PMIC to the minimum required (this is LDO target + > > > > min_dropout_uv). Without it by default VDD_ARM_SOC_IN will remain fixed > > > > as 1375mV from boot. > > > Who sets / guarantees that default value for ARM and SOC rails ? > > I think it's from the PMIC hardware itself (but maybe uboot plays with > > it). VDD_ARM_SOC_IN on this board is tied to SW1AB from MMPF0200: > > > > http://www.nxp.com/assets/documents/data/en/data-sheets/MMPF0200.pdf > > > > It seems reasonable to rely on such voltages set externally. > Isn't it an established rule that Linux should not depend on bootloader > settings ? Or did that change ? I don't actually know. Is there a hard and fast rule about this, even when it comes to voltages? In theory it is possible for a bootloader to set a low cpu frequency and low voltage and then have the chip fail when the cpufreq driver attempts to go higher. Setting vin-supply on reg_arm/reg_soc would fix that. > Well the regulator(s) cannot be correctly configured if the kernel > doesn't have the correct power distribution described in the DT . It depends on your definition of "correctness". It it certainly possible to get a functional system while only partially describing regulator relationships. I think there is a further misunderstanding here. I have a problem where imx6sx-sdb rev C boards crash on boot with upstream (but are reported to work fine with rev B). Removing the OPP overrides fixes this specific issue. I don't object to the second part of your patch, setting correct supply links is a good thing for various reasons. It is just not necessary for fixing the concrete crash mentioned above (and I tested this). It should probably go in a separate patch. It might seem a pedantic difference but it's good to accurately describe the effect of patches in commit messages. For example it might help somebody looking to backport various fixes. -- Regards, Leonard