From: Bastien Nocera <hadess@hadess.net>
To: Justin Vreeland <justin@jvreeland.com>,
gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses
Date: Thu, 04 May 2017 13:30:45 +0200 [thread overview]
Message-ID: <1493897445.22420.37.camel@hadess.net> (raw)
In-Reply-To: <20170502005254.10749-4-justin@jvreeland.com>
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Enclosing macros with complex values ensures expression is evaluated
> as
> expected.
>
> Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> v2:
> - Added spaces around plus signs
> - Fixed line over 80 columns
> - Added commit message
>
> drivers/staging/rtl8723bs/hal/odm.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h
> b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..87a76bafecb3 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21
> /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14 + 24 + 21)
> /* Channels_2_4G_NUM
> + * +
> Channels_5G_20M_NUM
> + * + Channels_5G
> + */
This does line up when applied, right? If so:
Reviewed-by: Bastien Nocera <hadess@hadess.net>
next prev parent reply other threads:[~2017-05-04 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 0:52 [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes Justin Vreeland
2017-05-02 0:52 ` [PATCH v2 1/7] staging: rtl8723bs: Fix initialization of static variables Justin Vreeland
2017-05-02 0:52 ` [PATCH v2 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop Justin Vreeland
2017-05-02 0:52 ` [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland
2017-05-04 11:30 ` Bastien Nocera [this message]
2017-05-02 0:52 ` [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland
2017-05-04 11:30 ` Bastien Nocera
2017-05-05 22:01 ` Justin Vreeland
2017-05-05 22:10 ` Justin Vreeland
2017-05-06 9:32 ` Bastien Nocera
2017-05-02 0:52 ` [PATCH v2 5/7] staging: rtl8723bs: Fix pointer style Justin Vreeland
2017-05-02 0:52 ` [PATCH v2 6/7] staging: rtl8723bs: Fix spacing around '<' Justin Vreeland
2017-05-02 0:52 ` [PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition Justin Vreeland
2017-05-04 11:31 ` [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493897445.22420.37.camel@hadess.net \
--to=hadess@hadess.net \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=justin@jvreeland.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox