From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbdEDL6s (ORCPT ); Thu, 4 May 2017 07:58:48 -0400 Received: from slow1-d.mail.gandi.net ([217.70.178.86]:55109 "EHLO slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdEDL6c (ORCPT ); Thu, 4 May 2017 07:58:32 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1493897445.22420.37.camel@hadess.net> Subject: Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses From: Bastien Nocera To: Justin Vreeland , gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 04 May 2017 13:30:45 +0200 In-Reply-To: <20170502005254.10749-4-justin@jvreeland.com> References: <20170502005254.10749-1-justin@jvreeland.com> <20170502005254.10749-4-justin@jvreeland.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.1 (3.24.1-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: > Enclosing macros with complex values ensures expression is evaluated > as > expected. > > Signed-off-by: Justin Vreeland > --- > v2: >   - Added spaces around plus signs >   - Fixed line over 80 columns >   - Added commit message > >  drivers/staging/rtl8723bs/hal/odm.h | 5 ++++- >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm.h > b/drivers/staging/rtl8723bs/hal/odm.h > index 0b3541a91548..87a76bafecb3 100644 > --- a/drivers/staging/rtl8723bs/hal/odm.h > +++ b/drivers/staging/rtl8723bs/hal/odm.h > @@ -209,7 +209,10 @@ typedef struct _ODM_RATE_ADAPTIVE { >   >  #define AVG_THERMAL_NUM 8 >  #define IQK_Matrix_REG_NUM 8 > -#define IQK_Matrix_Settings_NUM 14+24+21 > /*  Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */ > +#define IQK_Matrix_Settings_NUM (14 + 24 + 21) > /*   Channels_2_4G_NUM > + * + > Channels_5G_20M_NUM > + * + Channels_5G > + */ This does line up when applied, right? If so: Reviewed-by: Bastien Nocera