From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "thierry.escande@collabora.com" <thierry.escande@collabora.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported
Date: Thu, 4 May 2017 15:19:31 +0000 [thread overview]
Message-ID: <1493911171.2692.0.camel@sandisk.com> (raw)
In-Reply-To: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com>
On Thu, 2017-05-04 at 11:43 +0200, Thierry Escande wrote:
> From: Derek Basehore <dbasehore@chromium.org>
>
> Some external hard drives don't support the sync command even though the
> hard drive has write cache enabled. In this case, upon suspend request,
> sync cache failures are ignored if the error code in the sense header is
> ILLEGAL_REQUEST. There's not much we can do for these drives, so we
> shouldn't fail to suspend for this error case. The drive may stay
> powered if that's the setup for the port it's plugged into.
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2017-05-04 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 9:43 [PATCH v2] sd: Ignore sync cache failures when not supported Thierry Escande
2017-05-04 15:19 ` Bart Van Assche [this message]
2017-05-05 9:02 ` Christoph Hellwig
2017-05-05 11:46 ` Thierry Escande
2017-05-09 1:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493911171.2692.0.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox