From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbdEDPUC (ORCPT ); Thu, 4 May 2017 11:20:02 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:59063 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbdEDPTf (ORCPT ); Thu, 4 May 2017 11:19:35 -0400 X-IronPort-AV: E=Sophos;i="5.38,287,1491235200"; d="scan'208";a="16111614" From: Bart Van Assche To: "thierry.escande@collabora.com" , "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported Thread-Topic: [PATCH v2] sd: Ignore sync cache failures when not supported Thread-Index: AQHSxLrshInLcSpYUUGYB+g8yOB+GKHkSjKA Date: Thu, 4 May 2017 15:19:31 +0000 Message-ID: <1493911171.2692.0.camel@sandisk.com> References: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com> In-Reply-To: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@sandisk.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;7:++aH0iBeaZW6lE/qiHZTx1qwZ1w0dxTf7//5yIrGVPzrY1kbZONXAHCrVNNm0FOFhiD9kMvthkCUN+FB/ye5hIAk9mvtrjZgZBDLO42Ty1Bi8RPOxxi8+wcEPF26aTETuMQRp2rF2U/zE93vxF74InjwgynUlJtCkKFy5NQvHpecn3EzPeM5VZpytNa5+2Q/tKsF8rhlLqrU8J+Snrr5H40v6bdy0G4ROWyPTZRunSBVuZxGWEvGJsqLGQIn/ef72MMV3j31OTir0ugDDuUviERsa9emrcNuj+eaM/gU/wcHaDE69j64LVo1rN3PqKgkzu75zwoI4bzjWb+JeUbV2g==;20:nG4dZtFOIMWpke6xC/9EeTG65RIsHchjN8NFPhcRuEfKmgMMWtvdiGsa1LiTtR6g1jMTKTosCym3MxF4N6uppNxTWly2rbi5rYu27sbLExz+3NWsiO5JwPSDZlXxYXmVzlWuoviUZL0J1wbLenC3tyLb+waa4nWGImCfPQirSfA= x-ms-office365-filtering-correlation-id: ff2a2f26-4a5a-4e62-99c1-08d49300f6fa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR0401MB1533; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1533; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(39410400002)(39400400002)(39850400002)(39860400002)(39450400003)(39840400002)(377424004)(24454002)(122556002)(53936002)(2906002)(33646002)(189998001)(3280700002)(2900100001)(4326008)(3660700001)(86362001)(7736002)(54906002)(99286003)(6436002)(305945005)(6246003)(229853002)(2201001)(2950100002)(478600001)(38730400002)(5660300001)(6512007)(2501003)(50986999)(36756003)(77096006)(76176999)(8936002)(103116003)(54356999)(8676002)(25786009)(6506006)(6486002)(81166006)(102836003)(6116002)(3846002)(66066001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2017 15:19:31.8293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v44FLsi9013152 On Thu, 2017-05-04 at 11:43 +0200, Thierry Escande wrote: > From: Derek Basehore > > Some external hard drives don't support the sync command even though the > hard drive has write cache enabled. In this case, upon suspend request, > sync cache failures are ignored if the error code in the sense header is > ILLEGAL_REQUEST. There's not much we can do for these drives, so we > shouldn't fail to suspend for this error case. The drive may stay > powered if that's the setup for the port it's plugged into. Reviewed-by: Bart van Assche