From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756212AbdEDRsE (ORCPT ); Thu, 4 May 2017 13:48:04 -0400 Received: from smtprelay0110.hostedemail.com ([216.40.44.110]:56437 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753467AbdEDRr5 (ORCPT ); Thu, 4 May 2017 13:47:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:2731:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6119:6238:7576:9707:10004:10400:10848:10967:11232:11658:11914:12555:12698:12737:12740:12895:13069:13149:13230:13311:13357:13439:13894:14181:14659:14721:21080:21324:21451:21627:30012:30041:30054:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: point92_a92cba78f14f X-Filterd-Recvd-Size: 1532 Message-ID: <1493920071.22125.37.camel@perches.com> Subject: Re: [net-ipv4] question about arguments position From: Joe Perches To: David Miller , garsilva@embeddedor.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 May 2017 10:47:51 -0700 In-Reply-To: <20170504.124600.627647229351638856.davem@davemloft.net> References: <20170504110755.Horde.9md-X4baf8TwOEKjGrXkelZ@gator4166.hostgator.com> <20170504.124600.627647229351638856.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Thu, 04 May 2017 11:07:54 -0500 > > > While looking into Coverity ID 1357474 I ran into the following piece > > of code at net/ipv4/inet_diag.c:392: > > Because it's been this way since at least 2005, it doesn't matter if > the order is correct or not.  What's there is the locked in behavior > exposed to userspace and changing it will break things for people. Adding a few comments around the code about why it is this way will help avoid future questions.