From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1
Date: Fri, 05 May 2017 09:49:25 -0700 [thread overview]
Message-ID: <1494002965.2399.15.camel@HansenPartnership.com> (raw)
In-Reply-To: <CA+55aFxEsgt9D6vZOXQuGWQsue_QLugRz1bCtnqt0LUpmP7+Uw@mail.gmail.com>
On Fri, 2017-05-05 at 09:33 -0700, Linus Torvalds wrote:
> On Fri, May 5, 2017 at 9:00 AM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> >
> > I'm not going to defend the earlier coding, but you've lost the
> > real device_add() calls in the merge, meaning the tpm devices don't
> > actually get made visible at all. I suspect assuming device_add()
> > is done by cdev_device_add() because of the name is going to be our
> > next anti-pattern, so you're at least ahead of the game ...
>
> Don't be silly. That's *exactly* what cdev_device_add() does.
Oh, you're right, sorry, I was going by the patches that were cc'd to
the TPM list, which only had the two line addition for
cdev_device_add() ... apparently no-one sent any updates. Yes, the new
function looks much better and the resolution works. Sorry for the
noise.
James
next prev parent reply other threads:[~2017-05-05 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 0:18 [GIT PULL] Char/Misc driver patches for 4.12-rc1 Greg KH
2017-05-05 2:28 ` Linus Torvalds
2017-05-05 16:00 ` James Bottomley
2017-05-05 16:33 ` Linus Torvalds
2017-05-05 16:49 ` James Bottomley [this message]
2017-05-05 16:38 ` Greg KH
2017-05-05 19:46 ` James Bottomley
2017-05-05 20:01 ` Linus Torvalds
2017-05-06 5:09 ` Stephen Rothwell
2017-05-06 18:00 ` Linus Torvalds
2017-05-06 18:12 ` James Bottomley
2017-07-12 4:50 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494002965.2399.15.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox