From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750905AbdEEQtc (ORCPT ); Fri, 5 May 2017 12:49:32 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:42244 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbdEEQtb (ORCPT ); Fri, 5 May 2017 12:49:31 -0400 Message-ID: <1494002965.2399.15.camel@HansenPartnership.com> Subject: Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1 From: James Bottomley To: Linus Torvalds Cc: Greg KH , Jarkko Sakkinen , Andrew Morton , Arnd Bergmann , Linux Kernel Mailing List Date: Fri, 05 May 2017 09:49:25 -0700 In-Reply-To: References: <20170505001808.GA16769@kroah.com> <1494000006.2399.7.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-05-05 at 09:33 -0700, Linus Torvalds wrote: > On Fri, May 5, 2017 at 9:00 AM, James Bottomley > wrote: > > > > I'm not going to defend the earlier coding, but you've lost the > > real device_add() calls in the merge, meaning the tpm devices don't > > actually get made visible at all. I suspect assuming device_add() > > is done by cdev_device_add() because of the name is going to be our > > next anti-pattern, so you're at least ahead of the game ... > > Don't be silly. That's *exactly* what cdev_device_add() does. Oh, you're right, sorry, I was going by the patches that were cc'd to the TPM list, which only had the two line addition for cdev_device_add() ... apparently no-one sent any updates. Yes, the new function looks much better and the resolution works. Sorry for the noise. James