From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbdEFMOl (ORCPT ); Sat, 6 May 2017 08:14:41 -0400 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:45871 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750993AbdEFMOg (ORCPT ); Sat, 6 May 2017 08:14:36 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3872:4321:4605:5007:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: beef49_7e6a20ef13158 X-Filterd-Recvd-Size: 1879 Message-ID: <1494072867.31950.23.camel@perches.com> Subject: Re: [PATCH] Staging: rtl8723bs: core: Fixed a brace coding style issue From: Joe Perches To: Rene Hickersberger , gregkh@linuxfoundation.org Cc: hadess@hadess.net, hdegoede@redhat.com, Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 06 May 2017 05:14:27 -0700 In-Reply-To: <20170506120046.6186-1-renehickersberger@gmx.net> References: <20170506120046.6186-1-renehickersberger@gmx.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-05-06 at 14:00 +0200, Rene Hickersberger wrote: > Fixed a brace coding style issue. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c [] > @@ -863,11 +863,10 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) > auth = &psecuritypriv->authenticator_ie[0]; > psecuritypriv->authenticator_ie[0] = (unsigned char)psecnetwork->IELength; > > - if ((psecnetwork->IELength-12) < (256-1)) { > + if ((psecnetwork->IELength-12) < (256-1)) > memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], psecnetwork->IELength-12); > - } else { > + else > memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], (256-1)); > - } Because the first 2 arguments are very long and identical, it's probably better to not use braces but use min() instead memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], min(psecnetwork->IELength - 12, 256 - 1));