From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbdEGXH1 (ORCPT ); Sun, 7 May 2017 19:07:27 -0400 Received: from smtprelay0245.hostedemail.com ([216.40.44.245]:36783 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753436AbdEGXH0 (ORCPT ); Sun, 7 May 2017 19:07:26 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3873:3874:4321:5007:6119:8957:9010:10004:10400:10848:11026:11232:11658:11914:12043:12296:12555:12740:12760:12895:13069:13161:13229:13311:13357:13439:13972:14659:14721:21080:21433:21434:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: arm20_4098cf2ac5b09 X-Filterd-Recvd-Size: 2002 Message-ID: <1494198442.31950.50.camel@perches.com> Subject: Re: [PATCH 3/3] Staging: rtl8712: ieee80211: fixed camelcase coding style issue From: Joe Perches To: Jaya Durga , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 07 May 2017 16:07:22 -0700 In-Reply-To: <1494184510-21422-1-git-send-email-jayad@cdac.in> References: <1494184510-21422-1-git-send-email-jayad@cdac.in> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-08 at 00:45 +0530, Jaya Durga wrote: > Fixed coding style issue Please list the various renames you are doing. BeaconPeriod -> beacon_period DSConfig -> ds_config ATIMWindow -> atim_window etc... And it's generally better to do these while avoiding changing line breaks. There are maintainers that also would want these renames done in individual separate patches. > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c [] > @@ -174,7 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv) > sz += 8; > ie += sz; > /*beacon interval : 2bytes*/ > - *(__le16 *)ie = cpu_to_le16((u16)pdev_network->Configuration.BeaconPeriod); > + *(__le16 *)ie = cpu_to_le16( > + (u16)pdev_network->configuration.beacon_period); It's also frequently better to use a temporary pointer and convert these relatively long indirections to something simpler like: *cfg = &pdev_network->configuration; *(__le16 *)ie = cpu_to_le16(cfg->beacon_period); etc... in separate patches.