From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbdEGXY4 (ORCPT ); Sun, 7 May 2017 19:24:56 -0400 Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:35735 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751309AbdEGXYz (ORCPT ); Sun, 7 May 2017 19:24:55 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3873:3874:4321:4385:5007:7903:8603:10004:10400:10848:11026:11232:11657:11658:11914:12043:12048:12296:12740:12760:12895:13069:13141:13230:13311:13357:13439:13869:14659:14721:21080:21451:21611:21617:30005:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: camp03_47b19a2135e41 X-Filterd-Recvd-Size: 1758 Message-ID: <1494199491.31950.52.camel@perches.com> Subject: Re: [PATCH v2] staging: lustre: llite: Fix variable length array warning From: Joe Perches To: Guru Das Srinagesh , oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 07 May 2017 16:24:51 -0700 In-Reply-To: <1494149009-2121-1-git-send-email-gurooodas@gmail.com> References: <1494149009-2121-1-git-send-email-gurooodas@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-05-07 at 02:23 -0700, Guru Das Srinagesh wrote: > Fix sparse warning "warning: Variable length array is used." by using > kmalloc_array to allocate the required amount of memory instead and > kfree to deallocate memory after use. [] > diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c [] > @@ -86,13 +86,17 @@ ll_xattr_set_common(const struct xattr_handler *handler, > const char *name, const void *value, size_t size, > int flags) > { > - char fullname[strlen(handler->prefix) + strlen(name) + 1]; > + int fullname_len = strlen(handler->prefix) + strlen(name) + 1; > + char *fullname = kmalloc_array(fullname_len, sizeof(char), GFP_KERNEL); Are you sure about using GFP_KERNEL and that sleeping is allowed for this function allocation?