From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbdEHG1t (ORCPT ); Mon, 8 May 2017 02:27:49 -0400 Received: from smtprelay0061.hostedemail.com ([216.40.44.61]:59740 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750797AbdEHG1s (ORCPT ); Mon, 8 May 2017 02:27:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3873:3874:4250:4321:5007:6119:7514:7522:7903:9038:10004:10400:10848:11026:11232:11657:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30046:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: way57_7e0238ec9543c X-Filterd-Recvd-Size: 2318 Message-ID: <1494224864.31950.56.camel@perches.com> Subject: Re: [V4] staging : rtl8188eu : remove void function return From: Joe Perches To: Greg KH , Surender Polsani Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Dan Carpenter Date: Sun, 07 May 2017 23:27:44 -0700 In-Reply-To: <20170508055913.GA18310@kroah.com> References: <1494222755-25850-1-git-send-email-surenderpolsani@gmail.com> <20170508055913.GA18310@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-08 at 07:59 +0200, Greg KH wrote: > On Mon, May 08, 2017 at 11:22:35AM +0530, Surender Polsani wrote: > > kernel coding style doesn't allow the return statement > > in void function. > > > > Signed-off-by: Surender Polsani > > --- > > Changes for v2: > > corrected subject line as suggested > > Changes for v3: > > modified from line as suggested by Greg KH > > placed a semicolon in label for fixing build error > > Changes for v4: > > changes made as suggested by Dan Carpenter No, Dan correctly suggested that the goto and the label be removed, not what has been done in this patch. > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c [] > > @@ -146,7 +146,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > > > > if (!hw_init_completed) > > goto skip_dm; > > - > > Why did you remove this line? I presume because of carelessness. > > /* ODM */ > > pmlmepriv = &Adapter->mlmepriv; > > > > @@ -165,7 +164,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > > skip_dm: > > /* Check GPIO to determine current RF on/off and Pbc status. */ > > /* Check Hardware Radio ON/OFF or not */ > > - return; > > + ; > > Why is the ';' still here? A label immediately before a function termination requires a statement after the label and before the last closing brace.