From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbdEIPMa (ORCPT ); Tue, 9 May 2017 11:12:30 -0400 Received: from smtprelay0167.hostedemail.com ([216.40.44.167]:36316 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751306AbdEIPM3 (ORCPT ); Tue, 9 May 2017 11:12:29 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:196:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3870:3871:3876:4321:5007:6121:10004:10400:10471:10848:11026:11232:11473:11658:11783:11914:12043:12555:12740:12895:13069:13255:13311:13357:13439:13894:14181:14659:14721:21080:21434:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: girl36_6bf08e471a119 X-Filterd-Recvd-Size: 2552 Message-ID: <1494282901.31950.73.camel@perches.com> Subject: Re: [PATCH 4/4] Staging: rtl8712: ieee80211:fixed warning line over 80 characters coding style issue From: Joe Perches To: Jaya Durga , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org In-Reply-To: <1494271365-32548-1-git-send-email-jayad@cdac.in> References: <1494271365-32548-1-git-send-email-jayad@cdac.in> Content-Type: text/plain; charset="ISO-8859-1" Date: Mon, 08 May 2017 15:35:01 -0700 Mime-Version: 1.0 X-Mailer: Evolution 3.22.6-1ubuntu1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-09 at 00:52 +0530, Jaya Durga wrote: > fixed warning line over 80 characters coding style issue > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/ieee80211.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c > index 42cb46c..a7152df 100644 > --- a/drivers/staging/rtl8712/ieee80211.c > +++ b/drivers/staging/rtl8712/ieee80211.c > @@ -222,7 +222,9 @@ unsigned char *r8712_get_wpa_ie(unsigned char *pie, int *wpa_ie_len, int limit) > pbuf = r8712_get_ie(pbuf, _WPA_IE_ID_, &len, limit); > if (pbuf) { > /*check if oui matches...*/ > - if (memcmp((pbuf + 2), wpa_oui_type, sizeof(wpa_oui_type))) > + if (memcmp( > + (pbuf + 2), wpa_oui_type, > + sizeof(wpa_oui_type))) > goto check_next_ie; > /*check version...*/ > memcpy((u8 *)&val16, (pbuf + 6), sizeof(val16)); This is a oddly written function. Perhaps something like this would be more obvious: unsigned char *r8712_get_wpa_ie(unsigned char *pie, int *wpa_ie_len, int limit) { u8 *pbuf = pie; while (1) { int len; pbuf = r8712_get_ie(pbuf, _WPA_IE_ID_, &len, limit); if (!pbuf) break; /* check if oui matches... */ if (memcmp(pbuf + 2, WPA_OUI_TYPE, sizeof(WPA_OUI_TYPE)) == 0 &&     get_unaligned_le16(pbuf + 6) == 0x0001) { *wpa_ie_len = *(pbuf + 1); return pbuf; } limit = limit - (pbuf - pie) - 2 - len; if (limit <= 0) break; pbuf += 2 + len; } *wpa_ie_len = 0; return NULL; }