From: Joe Perches <joe@perches.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>
Cc: David Laight <David.Laight@ACULAB.COM>,
"'Christophe JAILLET'" <christophe.jaillet@wanadoo.fr>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@savoirfairelinux.com"
<vivien.didelot@savoirfairelinux.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] net: dsa: loop: Check for memory allocation failure
Date: Tue, 09 May 2017 08:18:27 -0700 [thread overview]
Message-ID: <1494343107.20782.2.camel@perches.com> (raw)
In-Reply-To: <f9058de7-ef9e-f6eb-751d-72ffdce512bb@gmail.com>
On Mon, 2017-05-08 at 17:35 -0700, Florian Fainelli wrote:
> On 05/08/2017 04:46 PM, Julia Lawall wrote:
> > On Mon, 8 May 2017, Joe Perches wrote:
> > > Each time -EPROBE_DEFER occurs, another set of calls to
> > > dsa_switch_alloc and dev_kzalloc also occurs.
> > >
> > > Perhaps it'd be better to do:
> > >
> > > if (ps->netdev) {
> > > devm_kfree(&devmdev->dev, ps);
> > > devm_kfree(&mdiodev->dev, ds);
> > > return -EPROBE_DEFER;
> > > }
> >
> > Is EPROBE_DEFER handled differently than other kinds of errors?
>
> In the core device driver model, yes, EPROBE_DEFER is treated
> differently than other errors because it puts the driver on a retry queue.
>
> EPROBE_DEFER is already a slow and exceptional path, and this is a
> mock-up driver, so I am not sure what value there is in trying to
> balance devm_kzalloc() with corresponding devm_kfree()...
Example code should be as correct as possible.
next prev parent reply other threads:[~2017-05-09 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 5:29 [PATCH] net: dsa: loop: Check for memory allocation failure Christophe JAILLET
2017-05-06 14:45 ` Andrew Lunn
2017-05-07 23:22 ` Florian Fainelli
2017-05-08 12:05 ` David Laight
2017-05-08 12:32 ` Julia Lawall
2017-05-08 17:44 ` Joe Perches
2017-05-08 23:46 ` Julia Lawall
2017-05-09 0:35 ` Florian Fainelli
2017-05-09 0:39 ` Julia Lawall
2017-05-09 15:18 ` Joe Perches [this message]
2017-05-10 4:38 ` Christophe JAILLET
2017-05-10 4:46 ` Julia Lawall
2017-05-10 4:54 ` Marion & Christophe JAILLET
2017-05-08 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494343107.20782.2.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=f.fainelli@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox