From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751009AbdEIVQ7 (ORCPT ); Tue, 9 May 2017 17:16:59 -0400 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:41946 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750876AbdEIVQ5 (ORCPT ); Tue, 9 May 2017 17:16:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3870:3871:3872:3873:4321:5007:6691:7682:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: egg70_597fc7cd11e55 X-Filterd-Recvd-Size: 1447 Message-ID: <1494364612.4564.1.camel@perches.com> Subject: Re: checkpatch: Adjust regular expressions in $logFunctions From: Joe Perches To: SF Markus Elfring Cc: Andy Whitcroft , LKML , kernel-janitors@vger.kernel.org Date: Tue, 09 May 2017 14:16:52 -0700 In-Reply-To: References: <1494363154.20782.7.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-09 at 23:01 +0200, SF Markus Elfring wrote: > > Perl is odd enough already adding more non-capture groups > > when the arguments are clearly specified is harder to read. > > How do you think about to reformat the affected alternations? > Will it become appropriate to give each element a separate line there? I have no interest in changing checkpatch for no value. _maybe_, breaking up the file into separate tests in multiple files _could_ be useful.