From: Maarten ter Huurne <maarten@treewalker.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Antony Pavlov <antonynpavlov@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 0/3] MIPS: JZ4740: Move PWM driver to PWM framework
Date: Sun, 02 Sep 2012 23:34:32 +0200 [thread overview]
Message-ID: <1494411.dJ2nCQkPX8@hyperion> (raw)
In-Reply-To: <20120902192752.GA10930@avionic-0098.mockup.avionic-design.de>
On Sunday 02 September 2012 21:27:53 Thierry Reding wrote:
> On Sun, Sep 02, 2012 at 03:25:55PM +0200, Maarten ter Huurne wrote:
> > I tested the "for-next" branch on the Dingoo A320 with the pwm-backlight
> > driver. It didn't work at first, because the PWM number and the timer
> > number didn't align: I requested PWM number 5 to get PWM7 and the GPIO
> > of PWM7 was used, but with timer 5 instead of timer 7, resulting in a
> > dark screen. However, it works fine after adding PWM0/1 as described
> > above.
>
> I haven't seen any usage of the pwm-backlight driver in mainline. I
> assume this is only present in some downstream repository?
Yes, the Dingoo A320 support is currently only available in the qi-kernel
repository. We have some essential drivers (the SLCD framebuffer driver in
particular) that are in their current state just too ugly to submit to
mainline.
> > If other people want to test on real hardware, you can find the code in
> > branch jz-3.6-rc2-pwm in the qi-kernel repository. Unfortunately our web
> > interface for git is still broken, but the repo itself is fine.
> >
> > git://projects.qi-hardware.com/qi-kernel.git
This is where you can find the code. The relevant configs are
qi_lb60_defconfig and a320_defconfig.
> An alternative approach would be to change pwm_chip.base from -1
> (dynamically allocated) to 2, which would leave 0 and 1 unavailable.
> That should at least solve the problem that you had regarding the GPIO
> and timer mismatch.
That could work, but the hardware does have PWM0 and PWM1, which are just
not available in our kernel, so adding them in busy state would better
describe real situation.
Maybe at some point we'll have a generic timer framework as well and then
having PWM0/1 defined but not requestable because the timers are busy would
be a natural fit.
> But the above also sounds sensible, and since both you and Lars agree
> that this is the better option, I can squash these changes into my patch
> with your permission.
Yes, please do.
Bye,
Maarten
prev parent reply other threads:[~2012-09-02 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 9:52 [PATCH 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Thierry Reding
2012-09-02 9:52 ` [PATCH 1/3] MIPS: JZ4740: Break circular header dependency Thierry Reding
2012-09-02 14:48 ` Lars-Peter Clausen
2012-09-02 19:16 ` Thierry Reding
2012-09-02 9:52 ` [PATCH 2/3] MIPS: JZ4740: Export timer API Thierry Reding
2012-09-02 14:45 ` Lars-Peter Clausen
2012-09-02 20:21 ` Thierry Reding
2012-09-02 20:27 ` Lars-Peter Clausen
2012-09-02 20:46 ` Thierry Reding
2012-09-02 9:52 ` [PATCH 3/3] pwm: Add Ingenic JZ4740 support Thierry Reding
2012-09-02 14:44 ` Lars-Peter Clausen
2012-09-02 19:59 ` Thierry Reding
2012-09-02 20:22 ` Lars-Peter Clausen
2012-09-02 20:37 ` Thierry Reding
2012-09-02 13:25 ` [PATCH 0/3] MIPS: JZ4740: Move PWM driver to PWM framework Maarten ter Huurne
2012-09-02 19:27 ` Thierry Reding
2012-09-02 21:34 ` Maarten ter Huurne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494411.dJ2nCQkPX8@hyperion \
--to=maarten@treewalker.org \
--cc=antonynpavlov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox