From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754534AbdEJXQg (ORCPT ); Wed, 10 May 2017 19:16:36 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:45880 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750930AbdEJXQe (ORCPT ); Wed, 10 May 2017 19:16:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2729:2828:3138:3139:3140:3141:3142:3352:3622:3743:3865:3866:3867:3868:3872:4225:4250:4321:5007:8603:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12740:12760:12895:13069:13255:13311:13357:13439:13972:14181:14659:14721:21080:21627:30054:30070:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: jump73_1bc5d2b52bb4c X-Filterd-Recvd-Size: 1993 Message-ID: <1494458188.2028.5.camel@perches.com> Subject: Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size From: Joe Perches To: Bin Liu , Peter Ujfalusi Cc: tony@atomide.com, gregkh@linuxfoundation.org, vinod.koul@intel.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@kernel.org, linux-kernel@vger.kernel.org Date: Wed, 10 May 2017 16:16:28 -0700 In-Reply-To: <20170510170754.GA7154@uda0271908> References: <20170510084231.19302-1-peter.ujfalusi@ti.com> <20170510084231.19302-6-peter.ujfalusi@ti.com> <20170510170754.GA7154@uda0271908> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote: > On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote: > > We have one register for each EP to set the maximum packet size for both > > TX and RX. > > If for example an RX programming would happen before the previous TX > > transfer finishes we would reset the TX packet side. > > > > To fix this issue, only modify the TX or RX part of the register. [] > > diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c [] > > @@ -389,15 +389,19 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz, > > > > if (chdat->tx) { > > /* Send transfer_packet_sz packets at a time */ > > - musb_writel(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET, > > - chdat->transfer_packet_sz); > > + u32 psize = musb_readl(ep_conf, TUSB_EP_MAX_PACKET_SIZE_OFFSET); > > checkpatch.pl complains about declaration and assignment together. No it doesn't.