From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755990AbdEKNlV (ORCPT ); Thu, 11 May 2017 09:41:21 -0400 Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:48154 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755818AbdEKNlS (ORCPT ); Thu, 11 May 2017 09:41:18 -0400 From: Trond Myklebust To: "torvalds@linux-foundation.org" , "n.borisov.lkml@gmail.com" CC: "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "mhocko@suse.com" Subject: Re: [GIT PULL] Please pull NFS client fixes for 4.12 Thread-Topic: [GIT PULL] Please pull NFS client fixes for 4.12 Thread-Index: AQHSya0NrD4QrM982UyDRv5+dS7+KaHuw/6AgABhJAA= Date: Thu, 11 May 2017 13:41:12 +0000 Message-ID: <1494510068.6968.0.camel@primarydata.com> References: <1494434821.4764.1.camel@primarydata.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR11MB1357;7:WQu+Ta6VT88pvoBB3b3AxZPgbXyiCqnYfHuzLSnNQRU8L7Kq/zd8WPMhduc2aDVKX3ONhV/nlJ0XEolwQcNbPnfsXX/3Otna4NcpuH+FyJ03JPjaf4NNhTsQFS+Ykapzd95a42f//DolxA3V3kXuD+ENNQVecFpFWJ+jDb63GbhnG1nuXWmq5X2aQYfxuJWobJlf58amGojuzhHrJd9SWjaVAagRIG9ji2URs0g6F738sNMTNe2FuIK2ItO20feqlYWleXbnyqlgYZ1pNj8JU6tQsSF/QUKqhahZXzXww0NgG+nHZK9a8iBrl5E8OVjXkYxNOfTViCnV8AF8FRsYZQ==;20:48NaODeuNfjm5nopCAT/jBZWyyx4i9u4rrls3HLPGWQwAJXfz+FkSjBpeZlPAVIzlOfpMXVGPbdyJvi9ygLOBhnMnkHZRqpeApgqDg6Yhrb6N9XF4VZUBBVTBrVD/TOkzYPAyQLh06ZyMaMRvI0uKRo30zPkjxN8RnObRD3evUQ= x-ms-office365-filtering-correlation-id: 8c976864-e6b7-46d4-ba31-08d4987363b5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075);SRVR:MWHPR11MB1357; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(5213294742642); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(2016111802025)(20161123564025)(20161123562025)(20161123558100)(20161123560025)(6043046)(6072148);SRVR:MWHPR11MB1357;BCL:0;PCL:0;RULEID:;SRVR:MWHPR11MB1357; x-forefront-prvs: 0304E36CA3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39410400002)(39450400003)(39830400002)(39400400002)(377424004)(24454002)(122556002)(4326008)(3280700002)(53546009)(33646002)(103116003)(2906002)(3660700001)(3846002)(77096006)(6506006)(102836003)(6116002)(81166006)(8936002)(189998001)(6486002)(25786009)(39060400002)(53936002)(8676002)(54356999)(76176999)(50986999)(7736002)(5660300001)(36756003)(305945005)(6512007)(54906002)(2900100001)(229853002)(99286003)(38730400002)(2501003)(66066001)(6436002)(478600001)(2950100002)(575784001)(6246003)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR11MB1357;H:MWHPR11MB1359.namprd11.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <04BDBB63017DDC45B27C54CAFFB09A67@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2017 13:41:12.5155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1357 X-MC-Unique: qZIQ9kKGMSqiuLzvvR8esQ-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4BDfYKo005758 On Thu, 2017-05-11 at 10:53 +0300, Nikolay Borisov wrote: > > On 10.05.2017 19:47, Trond Myklebust wrote: > > Hi Linus, > > > > The following changes since commit > > 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3: > > > >   Linux 4.11-rc7 (2017-04-16 13:00:18 -0700) > > > > are available in the git repository at: > > > >   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs- > > for-4.12-1 > > > > for you to fetch changes up to > > 76b2a303384e1d6299c3a0249f0f0ce2f8f96017: > > > >   pNFS/flexfiles: Always attempt to call layoutstats when flexfiles > > is enabled (2017-05-09 16:02:57 -0400) > > > > ---------------------------------------------------------------- > > NFS client updates for Linux 4.12 > > > > Highlights include: > > > > Stable bugfixes: > > - Fix use after free in write error path > > - Use GFP_NOIO for two allocations in writeback > > - Fix a hang in OPEN related to server reboot > > - Check the result of nfs4_pnfs_ds_connect > > - Fix an rcu lock leak > > > > Features: > > - Removal of the unmaintained and unused OSD pNFS layout > > - Cleanup and removal of lots of unnecessary dprintk()s > > - Cleanup and removal of some memory failure paths now that > >   GFP_NOFS is guaranteed to never fail. > > What guarantees that? Since if this is the case then this can result > in > a lot of opportunities for cleanup across the whole kernel tree. > After > discussing with mhocko (cc'ed) it seems that in practice everything > below COSTLY_ORDER which are not GFP_NORETRY will never fail. But > this > semantic is not the same as GFP_NOFAIL. E.g. nothing guarantees that > this will stay like that in the future? > Actually, going back to the code with coffee: it's the fact we have mempools, with direct reclaim that guarantee this. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com