From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jean Delvare <jdelvare@suse.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
bbaude@redhat.com, mildred-bug.kernel@mildred.fr,
barnacs@justletit.be, lvuksta@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems
Date: Mon, 15 May 2017 14:14:38 +0300 [thread overview]
Message-ID: <1494846878.6967.58.camel@linux.intel.com> (raw)
In-Reply-To: <20170515110103.59765-4-mika.westerberg@linux.intel.com>
On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote:
> It turns out there are quite many Chromebooks out there that have the
> same keyboard issue than Acer Chromebook. All of them are based on
> Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
> "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are
> exceptions
> for which we add separate entries).
>
> Instead of adding each machine to the quirk table, we use
> DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
> machines out there currently.
>
>
> + .ident = "Intel_Strago based Chromebooks",
> + .ident = "Cyan Chromebook",
> + .ident = "Samsung Chromebook 3",
I would do something like below (though I'm fine with current as well).
.ident = "Intel_Strago based Chromebooks (All models)",
.ident = "Intel_Strago based Chromebooks (Cyan)",
.ident = "Samsung Chromebook 3 (Celes)",
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-05-15 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 11:01 [PATCH 0/3] pinctrl: cherryview: Extend the DMI quirk to Intel_Strago systems Mika Westerberg
2017-05-15 11:01 ` [PATCH 1/3] firmware: dmi: Add DMI_PRODUCT_FAMILY identification string Mika Westerberg
2017-05-15 11:01 ` [PATCH 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Mika Westerberg
2017-05-15 11:01 ` [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel_Strago systems Mika Westerberg
2017-05-15 11:14 ` Andy Shevchenko [this message]
2017-05-15 11:19 ` Mika Westerberg
2017-05-15 22:26 ` Dmitry Torokhov
2017-05-23 8:00 ` [PATCH 0/3] pinctrl: cherryview: Extend the " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494846878.6967.58.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=barnacs@justletit.be \
--cc=bbaude@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvuksta@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mildred-bug.kernel@mildred.fr \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox