From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965755AbdEOOyA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 15 May 2017 10:54:00 -0400
Received: from mga06.intel.com ([134.134.136.31]:33780 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934147AbdEOOx6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 May 2017 10:53:58 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,345,1491289200"; 
   d="scan'208";a="100809406"
Message-ID: <1494860034.18055.17.camel@gmail.com>
Subject: Re: [PATCH] ubifs: Fix inode leak in xattr code
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
        stable@vger.kernel.org
Date: Mon, 15 May 2017 17:53:54 +0300
In-Reply-To: <1494858005-18439-1-git-send-email-richard@nod.at>
References: <1494858005-18439-1-git-send-email-richard@nod.at>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-05-15 at 16:20 +0200, Richard Weinberger wrote:
> To solve this problem, set i_nlink for all xattr inodes to 0, such
> that
> the iput() in the UBIFS xattr code makes the temporary inode vanish
> immediately.

What if there is iget right after iput? With this patch, will we need
to go all the way to the slow media instead of just getting having the
inode from the inode cache?