From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH] ubifs: Fix inode leak in xattr code
Date: Mon, 15 May 2017 19:05:39 +0300 [thread overview]
Message-ID: <1494864339.18055.20.camel@gmail.com> (raw)
In-Reply-To: <a5e7b80e-e1db-7b57-3b94-4d8e3a43cc6a@nod.at>
On Mon, 2017-05-15 at 17:22 +0200, Richard Weinberger wrote:
> Alternatively we could add a iget_locked/drop_nlink/iput sequence to
> ubifs_tnc_remove_ino(). But that will make unlink() much slower for
> files
> that contain xattrs.
At that level we'd need to do it for every xattr, even those that were
never be accessed, which would be slow indeed.
But we really only need to check the inode cache: hey, icache, I am
dying, and if you have any of my guys (xattrs), I want them to die with
me.
So the question is how to find our guys in the inode cache. I am not
sure. Probably be we'd have to have our own list of cached inodes in
the host inode, and maintain it.
Artem.
next prev parent reply other threads:[~2017-05-15 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 14:20 [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger
2017-05-15 14:53 ` Artem Bityutskiy
2017-05-15 15:22 ` Richard Weinberger
2017-05-15 16:05 ` Artem Bityutskiy [this message]
2017-05-15 16:22 ` Richard Weinberger
2017-05-15 17:57 ` Richard Weinberger
2017-05-16 22:20 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494864339.18055.20.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox