Re: [PATCH V16 09/11] ras: acpi / apei: generate trace event for unrecognized CPER section

Borislav Petkov
2017-05-16T14:38:12Z

On Mon, May 15, 2017 at 03:27:58PM -0600, Tyler Baicar wrote:
> The UEFI spec includes non-standard section type support in the
> Common Platform Error Record. This is defined in section N.2.3 of
> UEFI version 2.5.
>
> Currently if the CPER section's type (UUID) does not match any
> section type that the kernel knows how to parse, a trace event is
> not generated.
>
> Generate a trace event which contains the raw error data for
> non-standard section type error records.
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> CC: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
> Tested-by: Shiju Jose <shiju.jose@huawei.com>
> ---
> drivers/acpi/apei/ghes.c | 27 +++++++++++++++++++++++----
> drivers/ras/ras.c | 9 +++++++++
> include/linux/ras.h | 12 ++++++++++++
> include/ras/ras_event.h | 45 +++++++++++++++++++++++++++++++++++++++++++++
> include/uapi/linux/uuid.h | 6 ++++--
> 5 files changed, 93 insertions(+), 6 deletions(-)

This patch doesn't apply cleanly against 4.12-rc1. Please rediff it.

> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c
> index b67dd36..57363be 100644
> --- a/drivers/ras/ras.c
> +++ b/drivers/ras/ras.c
> @@ -7,11 +7,19 @@
>
> #include <linux/init.h>
> #include <linux/ras.h>
> +#include <linux/uuid.h>
>
> #define CREATE_TRACE_POINTS
> #define TRACE_INCLUDE_PATH ../../include/ras
> #include <ras/ras_event.h>
>
> +void call_non_standard_trace_event(const uuid_le *sec_type,

You are not calling a non-standard trace event - you're logging it:

log_non_standard_event()

> + const uuid_le *fru_id, const char *fru_text, const u8 sev,
> + const u8 *err, const u32 len)

Align arguments at opening brace.

> +{
> + trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len);
> +}
> +
> static int __init ras_init(void)
> {
> int rc = 0;

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.